Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badges show on docs.ropensci.org for some pkgs #100

Open
dpprdan opened this issue Oct 17, 2022 · 9 comments
Open

badges show on docs.ropensci.org for some pkgs #100

dpprdan opened this issue Oct 17, 2022 · 9 comments

Comments

@dpprdan
Copy link

dpprdan commented Oct 17, 2022

For some packages, e.g. opencage, the badges in the README.md don't show on https://docs.ropensci.org/opencage/ (or only the one for peer-review in the sidebar).

Other examples are:

I (vaguely) suspect the <!-- badges: start --> comments to be the culprit as that seems to be the common denominator of the repos above.

@jeroen
Copy link
Contributor

jeroen commented Oct 17, 2022

I think this is intended? We only show the software review badge now in the docs page: #95

@maelle
Copy link
Contributor

maelle commented Oct 17, 2022

yes, it's a choice in pkgdown to not show badges on production websites, and we re-add the software review badge.

@dpprdan
Copy link
Author

dpprdan commented Oct 17, 2022

That's also great, but then it is inconsistent, because there are badges (in the main page, not the sidebar) on e.g.:

pkgdown only filters out the <!-- badges --> block then, I assume. (I guess, we could add a note to use the comments to devguide here?)

All in all not a big issue, though, so we can close this, IMO.

@maelle
Copy link
Contributor

maelle commented Oct 17, 2022

No, you're right, its annoying. One of these days I should probably do a round and make PRs to fix a bunch of READMEs. 😅

@dpprdan
Copy link
Author

dpprdan commented Oct 17, 2022

pkgdown only filters out the <!-- badges --> block then, I assume.

Uh, maybe not. Counterexample: rotl has badges, and a <!-- badges --> block.

@maelle
Copy link
Contributor

maelle commented Oct 17, 2022

@dpprdan
Copy link
Author

dpprdan commented Oct 17, 2022

pkgdown.r-lib.org/reference/build_home.html#dev-badges

I think rotl passes those requirements (I read them as "or" reqs). Maybe they show up because the badges block comes before the title?

@maelle
Copy link
Contributor

maelle commented Oct 17, 2022

it might be r-lib/pkgdown#2060

@dpprdan dpprdan changed the title badges don't show on docs.ropensci.org for some pkgs badges ~~don't~~ show on docs.ropensci.org for some pkgs Oct 17, 2022
@dpprdan dpprdan changed the title badges ~~don't~~ show on docs.ropensci.org for some pkgs badges show on docs.ropensci.org for some pkgs Oct 17, 2022
@maelle
Copy link
Contributor

maelle commented Oct 25, 2022

For info r-lib/pkgdown#2220 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants