-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terra #86
base: master
Are you sure you want to change the base?
Terra #86
Conversation
… difference is the need to specify a crs by default.
…ling functionality, and a new arg for the crs.
Uh, excellent! I like that very much, in my daily work I rarely use raster anymore. Makes total sense to integrate this here ... will go through your PR and check it, thanks a ton! |
Hi, |
Hi Jette,
thanks for nudging, I totally forgot about this issue :-) I'll try to schedule this for beginning of December. Cheers, Sebastian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
OK, I'll have another go later this month |
Hi folks,
Thank you so much for this excellent package. I've been using nlm_randomcluster in my work a great deal. We generally use
terra
for raster operations now. For alignment with the rest of our work, I've updated nlm_percolation.R and nlm_randomcluster.R to work with terra. In my testing, they seem to produce analogous results in roughly 20% of the time.Tests have been updated, along with code, in a new branch terra.
If you're open to it, I'd love to work on the rest of the functions. They haven't been a priority for us so far, but it's been fun doing the work and I'd appreciate the opportunity to continue to contribute. Irrespective, I hope this can support your work a bit!
Thanks again!
Warmly,
Chris