Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terra #86

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Terra #86

wants to merge 11 commits into from

Conversation

chrismallon
Copy link

Hi folks,

Thank you so much for this excellent package. I've been using nlm_randomcluster in my work a great deal. We generally use terra for raster operations now. For alignment with the rest of our work, I've updated nlm_percolation.R and nlm_randomcluster.R to work with terra. In my testing, they seem to produce analogous results in roughly 20% of the time.

Tests have been updated, along with code, in a new branch terra.

If you're open to it, I'd love to work on the rest of the functions. They haven't been a priority for us so far, but it's been fun doing the work and I'd appreciate the opportunity to continue to contribute. Irrespective, I hope this can support your work a bit!

Thanks again!
Warmly,
Chris

@marcosci
Copy link
Collaborator

marcosci commented Jan 7, 2022

Uh, excellent! I like that very much, in my daily work I rarely use raster anymore. Makes total sense to integrate this here ... will go through your PR and check it, thanks a ton!

@JetteReeg
Copy link

Hi,
I am currently updating some R tutorials (moving from raster to terra) using the nlmr package (great package btw - thanks for developing!) and I am wondering if there are currently any efforts to delete the raster dependency and move to terra?

@bitbacchus
Copy link
Collaborator

Hi Jette,

Hi, I am currently updating some R tutorials (moving from raster to terra) using the nlmr package (great package btw - thanks for developing!) and I am wondering if there are currently any efforts to delete the raster dependency and move to terra?

thanks for nudging, I totally forgot about this issue :-)

I'll try to schedule this for beginning of December.

Cheers,

Sebastian

Copy link
Collaborator

@bitbacchus bitbacchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bitbacchus
Copy link
Collaborator

OK, I'll have another go later this month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants