Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env_unlock() will be removed from rlang #258

Open
lionel- opened this issue Apr 30, 2024 · 5 comments
Open

env_unlock() will be removed from rlang #258

lionel- opened this issue Apr 30, 2024 · 5 comments

Comments

@lionel-
Copy link

lionel- commented Apr 30, 2024

Hello, just a heads up that we'll remove env_unlock() from rlang in a future version (undetermined timeline as of yet) because it's implemented using non-API calls that CRAN has started to lint. Could you try and find another approach please?

@cboettig
Copy link
Member

cboettig commented May 6, 2024

@lionel- Thanks for the heads up. Do you have a better suggestion then for how to deal with the namespace conflict that is created by cli ? The current use of env_unlock() in this package was provided by @gaborcsardi to address the conflict between competing classes of the same name, #251 (comment)

@gaborcsardi
Copy link

The root of the issue was fixed in R 4.2.0, so you should not need this workaround any more.

@cboettig
Copy link
Member

cboettig commented May 6, 2024

perfect, thanks @gaborcsardi !

@hlapp
Copy link
Contributor

hlapp commented May 13, 2024

@cboettig looks like you addressed this in f94903a but there is no PR and the build fails. Would you mind if I reopen this and we create a PR for documentation?

@hlapp hlapp reopened this May 13, 2024
@cboettig
Copy link
Member

@hlapp yes thanks, I was sloppy on that!

Regarding the builds, it's probably time to update the workflow script as well, which can be done with usethis::use_github_actions()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants