New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimeProvider: add fuzzy parser to allow all sorts of date formats #107

Open

sckott opened this issue Feb 14, 2019 · 1 comment

Labels

feature

Collaborator

sckott commented Feb 14, 2019

lubridate not an option, too many deps
https://github.com/gaborcsardi/parsedate maybe, but no time zone support that I need
https://cran.r-project.org/web/packages/anytime/ Rcpp and BH though, pretty heavy, though we do already import tibble, so Rcpp is already needed

Collaborator Author

sckott commented Feb 14, 2019

gabor suggested calling as.POSIXlt on the result gaborcsardi/parsedate#25

as.POSIXlt(parsedate::parse_date("January 4, 1981 15:00:00"), tz="UTC")
#> [1] "1981-01-04 15:00:00 UTC"

seems to do the job. will investigate further.

also do performance comparisons

sckott added a commit that referenced this issue


          comment out datetimeprovider eg that is waiting on #107

33222ac

RMHogervorst added the feature label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment