Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long-term large change: make >1 of a thing faster #113

Open
sckott opened this issue Oct 1, 2020 · 0 comments
Open

long-term large change: make >1 of a thing faster #113

sckott opened this issue Oct 1, 2020 · 0 comments
Milestone

Comments

@sckott
Copy link
Collaborator

sckott commented Oct 1, 2020

Throughout the package we generally have each function that generate some fake thing make 1 of them. And then if a user wants more than 1 then they run it many times via for, replicate, apply, etc. This is probably not the fastest approach.

Maybe we make all methods accept a n parameter, with default n=1. Internally within each method we would use the fastest approach for whatever is being generated. This would add more complexity of course.

RMHogervorst added a commit that referenced this issue Nov 27, 2023
First attempts to quantify speed of
charlatan. Instantiating multiple R6 classes is
slow, very visible in fraudster() which initiates
all of the providers.

Relates to #113
@RMHogervorst RMHogervorst added this to the v0.7 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants