Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize the way we call other providers #128

Open
RMHogervorst opened this issue Oct 2, 2022 · 2 comments
Open

standardize the way we call other providers #128

RMHogervorst opened this issue Oct 2, 2022 · 2 comments
Labels
internals Internal changes

Comments

@RMHogervorst
Copy link
Contributor

F.i. in addresses and companies we call the person provider for every call.
I think it would be nicer if we put that provider in a standard slot so this is similar in all providers.

@RMHogervorst RMHogervorst added the internals Internal changes label Oct 2, 2022
@RMHogervorst
Copy link
Contributor Author

maybe in initialize we load those things in private with subclass(providername, self$locale)

@RMHogervorst
Copy link
Contributor Author

The way I do it in 0.6.0 is to put the provider in a slot in private:
private$pp <- PersonProvider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal changes
Projects
None yet
Development

No branches or pull requests

1 participant