Remove environment variables for testing ckanr on Github actions #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianm
reviewed
May 29, 2024
| @@ -153,9 +153,7 @@ check_organization <- function(url, x){ | |||
| } | |||
| } | |||
|
|
|||
| u <- get_test_url() | |||
There was a problem hiding this comment.
If we were to let get_test_url() have a default value that works here (i.e. "http://localhost:5000"), we could remove the environment secret from the GH repo as well as the env variable CKANR_TEST_URL in workflow R-check.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193
In #192 most of the environment variables were removed because they were being defined by prepare_test_ckan with the exception of CKANR_TEST_URL and CKANR_TEST_BEHAVIOUR.
We don't need to skip tests in Github Actionsand if we hardcode CKANR_TEST_URL this makes it easier to run thetest suite locally with docker compose because the only env var that needs to be defined is TEST_API_KEY as
described in https://github.com/ropensci/ckanr/blob/master/.github/CONTRIBUTING.md.
Edit. We do need to skip the tests for windows and macos runners but defining the variable CKANR_TEST_BEHAVIOUR directly brought some unintended consequences.