Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance about GitHub language detection #171

Closed
Bisaloo opened this issue May 27, 2019 · 6 comments
Closed

Add guidance about GitHub language detection #171

Bisaloo opened this issue May 27, 2019 · 6 comments

Comments

@Bisaloo
Copy link
Member

Bisaloo commented May 27, 2019

Feel free to move this issue if you think it belongs to another repo but I think it would make a worthwhile addition to the grooming section.

Some packages (including rOpenSci packages such as skimr, rsnps or rdflib) are mistakenly classified as HTML repos by GitHub. This hinders discoverability as they cannot be found in a search with the language: r filter.

It would be very useful to add pointers about how people can mitigate this issue (e.g. https://github.com/github/linguist#overrides).

@Bisaloo
Copy link
Member Author

Bisaloo commented May 27, 2019

Closing as this is apparently already the case. (I should definitely search more before opening new issues)

@Bisaloo Bisaloo closed this as completed May 27, 2019
@maelle
Copy link
Member

maelle commented May 27, 2019

so https://ropensci.github.io/dev_guide/grooming.html#github-linguist is sufficient then? if not feel free to reopen.

@Bisaloo
Copy link
Member Author

Bisaloo commented May 27, 2019

Yes, I'd say so. It's pretty close to what I had in mind anyways.

If I were to modify it, I would maybe more explicitly say that repos that don't follow this tip might not appear in search results with the language: r filter, as I mentioned in my first comment.

The current phrasing ("more discoverable") might not be clear enough to someone who didn't encounter this issue first hand.

@Bisaloo
Copy link
Member Author

Bisaloo commented May 27, 2019

On a related note, are you sure that files in docs are ignored by default?

If you store html files in non standard places (not in docs/, e.g. in vignettes/)

See e.g. https://github.com/ropensci/rdflib. I seem to remember that we also had to manually override linguist settings for this in pavo.

Not 100% sure though. I would need to check.

@Bisaloo
Copy link
Member Author

Bisaloo commented May 27, 2019

Hum, according to linguist docs, yes, it should be ignored.

https://github.com/github/linguist#documentation

I'm not sure why rdflib is marked as HTML then. Maybe https://github.com/ropensci/rdflib/blob/master/slides/slides.html?

@maelle
Copy link
Member

maelle commented May 27, 2019

can you open a small PR for the updated phrasing please? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants