Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of digits #96

Closed
ateucher opened this issue Nov 18, 2016 · 4 comments
Closed

Number of digits #96

ateucher opened this issue Nov 18, 2016 · 4 comments
Milestone

Comments

@ateucher
Copy link
Member

Currently to_json includes 22 digits. The GDAL default is 7.

22 seems excessive to me. Should we reduce it? should it be controllable by an additional argument?

write_geojson methods for sp objects currently allows specification of digits via the precision argument in (default NULL)

@sckott
Copy link
Collaborator

sckott commented Nov 18, 2016

Agree to reduce it - I looked over the new GeoJSON spec, and it seems like 6 is a good number, or 7 for this package, not too different.

@ateucher
Copy link
Member Author

Great. How about 7, to be consistent with geojsonio::write_json which uses rgdal::writeOGR (so presumably uses GDAL's default 7)?

@sckott
Copy link
Collaborator

sckott commented Nov 18, 2016

7 sounds good.

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants