From f64427345e5f5173981b81aa3cec688cf9a1dc81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tam=C3=A1s=20Stirling?= <49147718+stitam@users.noreply.github.com> Date: Tue, 23 Jan 2024 10:08:19 +0100 Subject: [PATCH] Final edits before v0.5.4 (#25) --- DESCRIPTION | 2 +- NEWS.md | 8 ++++++++ README.Rmd | 2 +- README.md | 12 ++++-------- codemeta.json | 8 ++++---- cran-comments.md | 12 ++++++++++++ revdep/README.md | 38 -------------------------------------- revdep/check.R | 2 -- revdep/problems.md | 40 ---------------------------------------- 9 files changed, 30 insertions(+), 94 deletions(-) delete mode 100644 revdep/README.md delete mode 100644 revdep/check.R delete mode 100644 revdep/problems.md diff --git a/DESCRIPTION b/DESCRIPTION index 6f76bad..080f134 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -6,7 +6,7 @@ Description: Suite of tools for managing cached files, targeting Provides utilities to manage cache directories, including targeting files by path or by key; cached directories can be compressed and uncompressed easily to save disk space. -Version: 0.5.3 +Version: 0.5.4 Authors@R: c(person("Scott", "Chamberlain", role = "aut", comment = c(ORCID="0000-0003-2542-2202")), person("Tamás", "Stirling", role = c("ctb", "cre"), diff --git a/NEWS.md b/NEWS.md index a2e493d..5554a52 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,11 @@ +hoardr 0.5.4 +============ + +### BUG FIXES + +* `testthat::test_check()` failed when full path for cache dir was `tempdir()`. +Replaced `tempdir()` with a full path that works (#23). + hoardr 0.5.3 ============ diff --git a/README.Rmd b/README.Rmd index cb8773a..45093dc 100644 --- a/README.Rmd +++ b/README.Rmd @@ -18,7 +18,7 @@ knitr::opts_chunk$set( [![status](https://www.repostatus.org/badges/latest/active.svg)](https://www.repostatus.org/#active) [![cran checks](https://badges.cranchecks.info/worst/hoardr.svg)](https://badges.cranchecks.info/worst/hoardr.svg) [![R-check](https://github.com/ropensci/hoardr/workflows/R-check/badge.svg)](https://github.com/ropensci/hoardr/actions?query=workflow%3AR-check) -[![codecov.io](https://codecov.io/github/ropensci/hoardr/coverage.svg?branch=master)](https://codecov.io/github/ropensci/hoardr?branch=master) +[![codecov.io](https://codecov.io/github/ropensci/hoardr/coverage.svg?branch=master)](https://app.codecov.io/github/ropensci/hoardr?branch=master) [![rstudio mirror downloads](https://cranlogs.r-pkg.org/badges/hoardr)](https://cran.r-project.org/package=hoardr) [![cran version](https://www.r-pkg.org/badges/version/hoardr)](https://cran.r-project.org/package=hoardr) diff --git a/README.md b/README.md index 8686847..61d75c6 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ [![cran checks](https://badges.cranchecks.info/worst/hoardr.svg)](https://badges.cranchecks.info/worst/hoardr.svg) [![R-check](https://github.com/ropensci/hoardr/workflows/R-check/badge.svg)](https://github.com/ropensci/hoardr/actions?query=workflow%3AR-check) -[![codecov.io](https://codecov.io/github/ropensci/hoardr/coverage.svg?branch=master)](https://codecov.io/github/ropensci/hoardr?branch=master) +[![codecov.io](https://codecov.io/github/ropensci/hoardr/coverage.svg?branch=master)](https://app.codecov.io/github/ropensci/hoardr?branch=master) [![rstudio mirror downloads](https://cranlogs.r-pkg.org/badges/hoardr)](https://cran.r-project.org/package=hoardr) [![cran @@ -54,7 +54,7 @@ set cache path ``` r x$cache_path_set("foobar", type = 'tempdir') -#> [1] "/tmp/RtmpQCahl1/R/foobar" +#> [1] "/tmp/Rtmp4oqK58/R/foobar" ``` make the directory if doesn’t exist @@ -73,7 +73,7 @@ list the files ``` r x$list() -#> [1] "/tmp/RtmpQCahl1/R/foobar/foo.txt" +#> [1] "/tmp/Rtmp4oqK58/R/foobar/foo.txt" ``` details @@ -81,7 +81,7 @@ details ``` r x$details() #> -#> directory: /tmp/RtmpQCahl1/R/foobar +#> directory: /tmp/Rtmp4oqK58/R/foobar #> #> file: /foo.txt #> size: 0 mb @@ -95,10 +95,6 @@ x$list() #> character(0) ``` -## todo - -see [issue 1](https://github.com/ropensci/hoardr/issues/1) - ## Meta - Please [report any issues or diff --git a/codemeta.json b/codemeta.json index 877a0dd..0469360 100644 --- a/codemeta.json +++ b/codemeta.json @@ -8,13 +8,13 @@ "codeRepository": "https://github.com/ropensci/hoardr", "issueTracker": "https://github.com/ropensci/hoardr/issues", "license": "https://spdx.org/licenses/MIT", - "version": "0.5.3", + "version": "0.5.4", "programmingLanguage": { "@type": "ComputerLanguage", "name": "R", "url": "https://r-project.org" }, - "runtimePlatform": "R version 4.2.2 (2022-10-31)", + "runtimePlatform": "R version 4.3.2 (2023-10-31)", "provider": { "@id": "https://cran.r-project.org", "@type": "Organization", @@ -125,9 +125,9 @@ "applicationCategory": "Data", "isPartOf": "https://ropensci.org", "keywords": ["caching", "data", "files", "xml", "pdf", "r", "rstats", "r-package"], - "fileSize": "31.604KB", + "fileSize": "32.029KB", "releaseNotes": "https://github.com/ropensci/hoardr/blob/master/NEWS.md", "readme": "https://github.com/ropensci/hoardr/blob/master/README.md", - "contIntegration": ["https://github.com/ropensci/hoardr/actions?query=workflow%3AR-check", "https://codecov.io/github/ropensci/hoardr?branch=master"], + "contIntegration": ["https://github.com/ropensci/hoardr/actions?query=workflow%3AR-check", "https://app.codecov.io/github/ropensci/hoardr?branch=master"], "developmentStatus": "https://www.repostatus.org/#active" } diff --git a/cran-comments.md b/cran-comments.md index d048e4f..f7de202 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,3 +1,15 @@ +# hoardr 0.5.4 + +This patch release was submitted in response to a notification from the CRAN +team regarding a test failure which emerged recently. + +## revdepcheck results + +We checked 11 reverse dependencies (5 from CRAN + 6 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. + + * We saw 0 new problems + * We failed to check 0 packages + # hoardr 0.5.3 This patch release was submitted to CRAN because the maintainer of the project diff --git a/revdep/README.md b/revdep/README.md deleted file mode 100644 index e120e7d..0000000 --- a/revdep/README.md +++ /dev/null @@ -1,38 +0,0 @@ -# Platform - -|field |value | -|:--------|:-------------------------------------------| -|version |R version 3.5.1 Patched (2018-11-18 r75627) | -|os |macOS Mojave 10.14.1 | -|system |x86_64, darwin15.6.0 | -|ui |X11 | -|language |(EN) | -|collate |en_US.UTF-8 | -|ctype |en_US.UTF-8 | -|tz |US/Pacific | -|date |2018-12-01 | - -# Dependencies - -|package |old |new |Δ | -|:-------|:-----|:-----|:--| -|hoardr |0.5.0 |0.5.2 |* | - -# Revdeps - -## All (11) - -|package |version |error |warning |note | -|:----------------------------------------|:-------|:-----|:-------|:----| -|bomrang |0.4.0 | | | | -|crminer |0.2.0 | | | | -|[finch](problems.md#finch) |0.2.0 | | |1 | -|fulltext |1.1.0 | | | | -|[getCRUCLdata](problems.md#getcrucldata) |0.2.5 |1 | | | -|rcoreoa |0.3.0 | | | | -|rdpla |0.2.0 | | | | -|rerddap |0.4.2 | | | | -|rnoaa |0.7.0 | | | | -|taxizedb |0.1.4 | | | | -|traits |0.3.0 | | | | - diff --git a/revdep/check.R b/revdep/check.R deleted file mode 100644 index 4f115fe..0000000 --- a/revdep/check.R +++ /dev/null @@ -1,2 +0,0 @@ -library("revdepcheck") -revdep_check(num_workers = 4) diff --git a/revdep/problems.md b/revdep/problems.md deleted file mode 100644 index 26be21a..0000000 --- a/revdep/problems.md +++ /dev/null @@ -1,40 +0,0 @@ -# finch - -Version: 0.2.0 - -## In both - -* checking dependencies in R code ... NOTE - ``` - Namespace in Imports field not imported from: ‘rappdirs’ - All declared Imports should be used. - ``` - -# getCRUCLdata - -Version: 0.2.5 - -## In both - -* checking tests ... - ``` - ERROR - Running the tests in ‘tests/testthat.R’ failed. - Last 13 lines of output: - 1/1 mismatches - [1] 12.9 - 12.9 == 5.72e-07 - - ── 2. Failure: Test that create_stack creates tmn if requested (@test-create_CRU - raster::maxValue(CRU_stack_list[[1]][[1]]) not equal to 4.3. - 1/1 mismatches - [1] 4.3 - 4.3 == 1.91e-07 - - ══ testthat results ═══════════════════════════════════════════════════════════ - OK: 637 SKIPPED: 23 FAILED: 2 - 1. Failure: Test that create_stack creates tmx if requested (@test-create_CRU_stack.R#868) - 2. Failure: Test that create_stack creates tmn if requested (@test-create_CRU_stack.R#1233) - - Error: testthat unit tests failed - Execution halted - ``` -