Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export 'normalize_table' and 'poor_mans_nquads' #40

Open
James-G-Hill opened this issue Sep 27, 2021 · 3 comments
Open

Export 'normalize_table' and 'poor_mans_nquads' #40

James-G-Hill opened this issue Sep 27, 2021 · 3 comments

Comments

@James-G-Hill
Copy link

Hello, just a suggestion that 'normalize_table' and 'poor_mans_nquads' functions may be handy to export so that the user can call them with :: and not need ::: (which causes 'Check' to complain).

My initial use case for this was that I had a table where some entries were NA; using write_nquads directly was including the NAs as blank objects in my graph but it seemed unnecessary to include those triples if there's no object. An alternative of course would be to include an option to normalize_table to remove NAs but I think exposing these will give you the user more flexibility to customize their own variations on write_nquads.

@cboettig
Copy link
Member

Makes sense. I wonder if it wouldn't be better though to (also) change the behavior to avoid writing explicit NAs at all? What do you think? would you have any interest in preparing a PR for this?

@James-G-Hill
Copy link
Author

Hello, yes, I think it would be good to have both options; expose the underlying functions and also allow the user to add a boolean to remove NAs. I would be happy to prepare a PR for this in the near future although I'll be a little busy for a couple of weeks. Will come back to it though.

@cboettig
Copy link
Member

cboettig commented Oct 3, 2021

Thanks, a PR would be welcome but no rush, this package will still be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants