You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, just a suggestion that 'normalize_table' and 'poor_mans_nquads' functions may be handy to export so that the user can call them with :: and not need ::: (which causes 'Check' to complain).
My initial use case for this was that I had a table where some entries were NA; using write_nquads directly was including the NAs as blank objects in my graph but it seemed unnecessary to include those triples if there's no object. An alternative of course would be to include an option to normalize_table to remove NAs but I think exposing these will give you the user more flexibility to customize their own variations on write_nquads.
The text was updated successfully, but these errors were encountered:
Makes sense. I wonder if it wouldn't be better though to (also) change the behavior to avoid writing explicit NAs at all? What do you think? would you have any interest in preparing a PR for this?
Hello, yes, I think it would be good to have both options; expose the underlying functions and also allow the user to add a boolean to remove NAs. I would be happy to prepare a PR for this in the near future although I'll be a little busy for a couple of weeks. Will come back to it though.
Hello, just a suggestion that 'normalize_table' and 'poor_mans_nquads' functions may be handy to export so that the user can call them with
::
and not need:::
(which causes 'Check' to complain).My initial use case for this was that I had a table where some entries were NA; using
write_nquads
directly was including the NAs as blank objects in my graph but it seemed unnecessary to include those triples if there's no object. An alternative of course would be to include an option tonormalize_table
to remove NAs but I think exposing these will give you the user more flexibility to customize their own variations onwrite_nquads
.The text was updated successfully, but these errors were encountered: