Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbind_labelled bug #98

Open
OJWatson opened this issue Feb 26, 2020 · 0 comments
Open

rbind_labelled bug #98

OJWatson opened this issue Feb 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@OJWatson
Copy link
Collaborator

OJWatson commented Feb 26, 2020

Session Info

Couple of things have popped up with rbind_labelled that could be made tidier.

  1. Currently it checks the names of the first data frame against the rest to check they are there. If not it will error as follows.
better_bound <- rbind_labelled(extract[1:2], labels = l)
 Error in `[.data.frame`(X[[i]], ...) : undefined columns selected 

However, it would be best to either add a better message explaining this, or, just not care. Ideally, if variables are not shared then we should just fill with NA

  1. Concatenate all argument. We should have a flag that causes all haven_labelled class variables to be concatenated. Quite often this is the default approach and then people may recode variables afterwards once they are easier able to see all responses recorded across their data sets.
@OJWatson OJWatson added the bug Something isn't working label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant