Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcnd_splitvars Broken with dplyr v0.5.0 #156

Closed
lawinslow opened this issue Jun 28, 2016 · 5 comments
Closed

ghcnd_splitvars Broken with dplyr v0.5.0 #156

lawinslow opened this issue Jun 28, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@lawinslow
Copy link

After upgrading dplyr to v0.5.0 (current CRAN version), the rnoaa::ghcnd_splitvars function no longer works.

> minoc = ghcnd_splitvars(ghcnd('USC00475516'))
Error in is.string(match) : argument "match" is missing, with no default

Seems to fail right away on this select statement.

Downgraded to dplyr v0.4.3 and it works fine.

@lawinslow
Copy link
Author

Small world @sckott. Thanks for the noaa package.

@sckott sckott added the bug label Jun 28, 2016
@sckott
Copy link
Contributor

sckott commented Jun 28, 2016

thanks @lawinslow - sorry about that - i knew a new version was coming, should have caught it, will push a change soon - added new milestone for bug fixes https://github.com/ropensci/rnoaa/milestones/v0.5.8

@sckott sckott added this to the v0.6 milestone Jun 28, 2016
@sckott sckott self-assigned this Jun 28, 2016
@sckott sckott modified the milestones: v0.5.8, v0.6 Jun 28, 2016
@lawinslow
Copy link
Author

np, just thought you'd like to know.

@sckott sckott closed this as completed in 7a59bb3 Jul 1, 2016
@sckott
Copy link
Contributor

sckott commented Jul 1, 2016

@lawinslow try again after reinstall

@lawinslow
Copy link
Author

Great. Fixed. Thanks!

@sckott sckott modified the milestones: v0.5.8, v0.6 Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants