-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review all vignettes #154
Comments
One of the first chunks need to be changed to fstadv <- rrricanesdata::fstadv |> filter(Key == key, Adv <= adv) but then I get Quitting from lines 38-40 (forecast_advisory.Rmd)
Erreur dans st_sf(x, ..., agr = agr, sf_column_name = sf_column_name) :
no simple features geometry column present
Appels : <Anonymous> ... process_cpl_read_ogr -> st_as_sf -> st_as_sf.data.frame -> st_sf |
Were the vignettes fixed? Any help needed? |
@elinw 👋! Is any help needed? Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To get things to build we had to change a lot of the vignette chunks to eval=FALSE.We need to work through each one to get them all running.
Also let's add chunk names as much as possible and silence the messages that come with loading dplyr etc.
The text was updated successfully, but these errors were encountered: