-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route_graphhopper is out of date #389
Comments
Link to the graphopper repo: https://github.com/crazycapivara/graphhopper-r |
@Robinlovelace Good to know that you want to use the lib. I hope I can publish it soon on cran. |
Great, let me know if you want a hand with that. Looking good to me! |
Still not done but optional extra so closing for now. |
graphhopper is now on CRAN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think a package could be the best approach to keep it modular. Improvements on the current function could include:
After a bit of searching, I've realised that there's no need to, @crazycapivara has already created a modern interface that returns
sf
objects 🎉 Great work!The only remaining issue from this package's perspective are to:
route_graphhopper()
route()
withgraphhopper::gh_get_route()
and document as appropriateThe text was updated successfully, but these errors were encountered: