Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route_graphhopper is out of date #389

Closed
4 of 5 tasks
Robinlovelace opened this issue Apr 13, 2020 · 6 comments
Closed
4 of 5 tasks

route_graphhopper is out of date #389

Robinlovelace opened this issue Apr 13, 2020 · 6 comments

Comments

@Robinlovelace
Copy link
Member

Robinlovelace commented Apr 13, 2020

I think a package could be the best approach to keep it modular. Improvements on the current function could include:

  • use of their updated API
  • return of per-segment rather than per-route data
  • use of sf

After a bit of searching, I've realised that there's no need to, @crazycapivara has already created a modern interface that returns sf objects 🎉 Great work!

The only remaining issue from this package's perspective are to:

  • Deprecate route_graphhopper()
  • Test the use of route() with graphhopper::gh_get_route() and document as appropriate
@Robinlovelace
Copy link
Member Author

Link to the graphopper repo: https://github.com/crazycapivara/graphhopper-r

@crazycapivara
Copy link

@Robinlovelace Good to know that you want to use the lib. I hope I can publish it soon on cran.

@crazycapivara
Copy link

@Robinlovelace
Copy link
Member Author

Great, let me know if you want a hand with that. Looking good to me!

@Robinlovelace
Copy link
Member Author

Test the use of route() with graphhopper::gh_get_route() and document as appropriate

Still not done but optional extra so closing for now.

@crazycapivara
Copy link

graphhopper is now on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants