Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in the new version of osrm #488

Closed
rCarto opened this issue May 20, 2022 · 2 comments
Closed

Breaking change in the new version of osrm #488

rCarto opened this issue May 20, 2022 · 2 comments
Assignees

Comments

@rCarto
Copy link

rCarto commented May 20, 2022

Hello @Robinlovelace ,

I'll drop sp support in the next version of osrm. One effect of this is I have deprecated the use of returnclass arg in all relevant functions (including osrmRoute()). Functions will now exclusively return an sf object.
This change leads to a few warnings when checking stplanr (master and no-sp-2022 branches).

remotes::install_github("riatelab/osrm", ref = "refactor")

I could use a message instead of a warning (though it may not be the best practice). What do you think?

@Robinlovelace
Copy link
Member

Great stuff, I'm also dropping sp soon as per #332 and #481. So good timing!

@Robinlovelace
Copy link
Member

Happy for it to be a warning, will aim to fix my side.

@Robinlovelace Robinlovelace self-assigned this May 20, 2022
@rCarto rCarto closed this as completed Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants