[general] Some lints to fix in the package #1321
Closed
etiennebacher
started this conversation in
General
Replies: 1 comment
-
Sure, happy to review a PR. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Help
Description
Hello, I'm building a new package to find and automatically fix lints in R code:
flint
.I'm using real-life, large packages to check its performance and
targets
is one of them. Since I already test on this, proposing those changes doesn't add much cost. I ranflint::fix_package(exclude_linters = "outer_negation")
and fixed a wrong replacement by hand. The changes can be seen here: main...etiennebacher:targets:mainThere are many changes but most of them are trivial:
inherits()
instead of"foo" %in% class(x)
expect_named()
,expect_null()
, and other variants in testsetc.
flint
is quite new and linter rules are necessarily a bit opinionated, so some of those changes might not be to your taste, but I'd be happy to have some feedback on this. If you are ok with this idea, then I can open a PR.Beta Was this translation helpful? Give feedback.
All reactions