Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Process! (ROLLING LIVE ON JAMMY) 🟢 🍯 #1

Closed
8 of 14 tasks
methylDragon opened this issue Mar 17, 2022 · 11 comments
Closed
8 of 14 tasks

Release Process! (ROLLING LIVE ON JAMMY) 🟢 🍯 #1

methylDragon opened this issue Mar 17, 2022 · 11 comments
Assignees

Comments

@methylDragon
Copy link
Contributor

methylDragon commented Mar 17, 2022

[STATUS: RELEASED - LIVE ON JAMMY]

Buildfarm Status

  • Build Status dev (ubuntu_jammy_amd64)
  • Build Status doc (ubuntu_jammy_amd64)
  • Build Status src (rhel_8)
  • Build Status src (ubuntu_jammy)
  • Build Status bin (ubuntu_jammy_amd64)
  • Build Status bin (rhel_8_x86_64)
  • Build Status bin (ubuntu_jammy_arm64)

Description

This issue tracks the status for the release of this repository into rosdistro and making it available for installation as .deb via the ROS 2 repositories.

It will detail the steps that need to be taken, and what recommended changes are good to have.

Highlights

  • We need a LICENSE file.
  • Docs seem to build, but with errors (minor issue)
  • Remember to create a new release tag to reflect the change.

Ok

  • ament exports look ok

Release Process

Steps

Recommendations

  • You might want to add your email to the author tag on package.xml for consistency
  • It'll be good if you can get the linters to run cleanly
  • README.md with usage examples
  • Tests
  • You can try running rosdoc2 to see what documentation generation errors there are to fix
  • Please namespace your code, especially if this package is intended to be used by many other downstream packages. See doc and associated google style doc, you'll prevent clashes that way
@vmayoral
Copy link
Member

Addressed critical aspects and droped the Doxyfile (this was inherited from https://gitlab.com/ros-tracing/ros2_tracing/-/tree/master/tracetools, see ros-perception/image_pipeline#717 (comment) for the rationale of splitting things). There's no real relevant documentation so dropping it seems the simplest way for now.

@methylDragon
Copy link
Contributor Author

methylDragon commented Mar 24, 2022

Ok, got it. It's ok to omit your email from the author tag, though would it be possible to be namespacing the headers like the original? Or are there some blockers from Xilinx that are stopping this from happening?

I think specifically because this isn't Vitis specific and is used more generally, if you're intending to target a general community release, it'll be strongly recommended so people don't end up with namespace clashes.

@methylDragon methylDragon changed the title Release Process! Release Process! (CHANGES NEEDED) Mar 24, 2022
@vmayoral
Copy link
Member

Ok, got it. It's ok to omit your email from the author tag, though would it be possible to be namespacing the headers like the original? Or are there some blockers from Xilinx that are stopping this from happening?

I'm not quite following you. Neither with the author tag, nor with the original namespacing. Do you think you can send a PR to illustrate it?

@methylDragon
Copy link
Contributor Author

Apologies on the author tag, I think I was looking at a previous version.

Namespacing PR is here: #2

@methylDragon
Copy link
Contributor Author

Let's also get humble and rolling branches, then after the merge and release tag, I can do the release!

@methylDragon methylDragon changed the title Release Process! (CHANGES NEEDED) Release Process! (PENDING PR MERGE) Mar 29, 2022
@vmayoral
Copy link
Member

All done, thanks for the input @methylDragon!

Bloom release also made from my side. Please have a look at the resulting artifacts in case I did something wrong.

Bloom release process
xilinx@xilinx:~/ros2_ws/src/xilinx/tracetools_acceleration$ git tag 0.4.1^C
xilinx@xilinx:~/ros2_ws/src/xilinx/tracetools_acceleration$ bloom-release --rosdistro rolling --track rolling tracetools_acceleration --edit
ROS Distro index file associate with commit '725def91e71e2e1a9520416feb916c802ed75314'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/725def91e71e2e1a9520416feb916c802ed75314/index-v4.yaml'
Specified repository 'tracetools_acceleration' is not in the distribution file located at 'https://raw.githubusercontent.com/ros/rosdistro/725def91e71e2e1a9520416feb916c802ed75314/rolling/distribution.yaml'
Did you mean one of these: 'ament_acceleration', 'tracetools_analysis'?
Could not determine release repository url for repository 'tracetools_acceleration' of distro 'rolling'
You can continue the release process by manually specifying the location of the RELEASE repository.
To be clear this is the url of the RELEASE repository not the upstream repository.
For release repositories on GitHub, you should provide the `https://` url which should end in `.git`.
Here is the url for a typical release repository on GitHub: https://github.com/ros-gbp/rviz-release.git
==> Looking for a release of this repository in a different distribution...
No reasonable default release repository url could be determined from previous releases.
Release repository url [press enter to abort]: https://github.com/ros2-gbp/tracetools_acceleration-release.git
==> Fetching 'tracetools_acceleration' repository from 'https://github.com/ros2-gbp/tracetools_acceleration-release.git'
Cloning into '/tmp/tmpz_4gzvfv'...
remote: Enumerating objects: 170, done.
remote: Counting objects: 100% (170/170), done.
remote: Compressing objects: 100% (109/109), done.
remote: Total 170 (delta 37), reused 170 (delta 37), pack-reused 0
Receiving objects: 100% (170/170), 33.40 KiB | 877.00 KiB/s, done.
Resolving deltas: 100% (37/37), done.
Track 'rolling' exists, editing...
Repository Name:
  <name>
    Name of the repository (used in the archive name)
  upstream
    Default value, leave this as upstream if you are unsure
  ['upstream']:
Upstream Repository URI:
  <uri>
    Any valid URI. This variable can be templated, for example an svn url
    can be templated as such: "https://svn.foo.com/foo/tags/foo-:{version}"
    where the :{version} token will be replaced with the version for this release.
  ['https://github.com/ros-acceleration/tracetools_acceleration.git']:
Upstream VCS Type:
  git
    Upstream URI is a git repository
  hg
    Upstream URI is a hg repository
  svn
    Upstream URI is a svn repository
  tar
    Upstream URI is a tarball
  ['git']:
Version:
  :{auto}
    This means the version will be guessed from the devel branch.
    This means that the devel branch must be set, the devel branch must exist,
    and there must be a valid package.xml in the upstream devel branch.
  :{ask}
    This means that the user will be prompted for the version each release.
    This also means that the upstream devel will be ignored.
  <version>
    This will be the version used.
    It must be updated for each new upstream version.
  [':{auto}']:
Release Tag:
  :{version}
    This means that the release tag will match the :{version} tag.
    This can be further templated, for example: "foo-:{version}" or "v:{version}"

    This can describe any vcs reference. For git that means {tag, branch, hash},
    for hg that means {tag, branch, hash}, for svn that means a revision number.
    For tar this value doubles as the sub directory (if the repository is
    in foo/ of the tar ball, putting foo here will cause the contents of
    foo/ to be imported to upstream instead of foo itself).
  :{ask}
    This means the user will be prompted for the release tag on each release.
  :{none}
    For svn and tar only you can set the release tag to :{none}, so that
    it is ignored.  For svn this means no revision number is used.
  [':{version}']:
Upstream Devel Branch:
  <vcs reference>
    Branch in upstream repository on which to search for the version.
    This is used only when version is set to ':{auto}'.
  [None]:
ROS Distro:
  <ROS distro>
    This can be any valid ROS distro, e.g. indigo, kinetic, lunar, melodic
  ['rolling']:
Patches Directory:
  <path in bloom branch>
    This can be any valid relative path in the bloom branch. The contents
    of this folder will be overlaid onto the upstream branch after each
    import-upstream.  Additionally, any package.xml files found in the
    overlay will have the :{version} string replaced with the current
    version being released.
  :{none}
    Use this if you want to disable overlaying of files.
  [None]:
Release Repository Push URL:
  <url>
    (optional) Used when pushing to remote release repositories. This is only
    needed when the release uri which is in the rosdistro file is not writable.
    This is useful, for example, when a releaser would like to use a ssh url
    to push rather than a https:// url.
  :{none}
    This indicates that the default release url should be used.
  [None]:
Saving 'rolling' track.
==> Testing for push permission on release repository
==> git remote -v
origin	https://github.com/ros2-gbp/tracetools_acceleration-release.git (fetch)
origin	https://github.com/ros2-gbp/tracetools_acceleration-release.git (push)
==> git push --dry-run
To https://github.com/ros2-gbp/tracetools_acceleration-release.git
   cc7c2e0..49ee508  master -> master
==> Releasing 'tracetools_acceleration' using release track 'rolling'
==> git-bloom-release rolling
Processing release track settings for 'rolling'
Checking upstream devel branch '<default>' for package.xml(s)
Cloning into '/tmp/tmpt351jnic/upstream'...
remote: Enumerating objects: 83, done.
remote: Counting objects: 100% (83/83), done.
remote: Compressing objects: 100% (56/56), done.
remote: Total 83 (delta 45), reused 63 (delta 26), pack-reused 0
Unpacking objects: 100% (83/83), 20.83 KiB | 495.00 KiB/s, done.
Looking for packages in 'main' branch... found 'tracetools_acceleration'.
Detected version '0.4.1' from package(s): ['tracetools_acceleration']

Executing release track 'rolling'
==> bloom-export-upstream /tmp/tmpt351jnic/upstream git --tag 0.4.1 --display-uri https://github.com/ros-acceleration/tracetools_acceleration.git --name upstream --output-dir /tmp/tmp4qji16ly
Checking out repository at 'https://github.com/ros-acceleration/tracetools_acceleration.git' to reference '0.4.1'.
Exporting to archive: '/tmp/tmp4qji16ly/upstream-0.4.1.tar.gz'
Cloning into '/tmp/tmp9rp8jf8r'...
warning: --depth is ignored in local clones; use file:// instead.
done.
md5: db51f113000c70ebe195d7b88c6a278d

==> git-bloom-import-upstream /tmp/tmp4qji16ly/upstream-0.4.1.tar.gz  --release-version 0.4.1 --replace
The latest upstream tag in the release repository is 'upstream/0.4.0'.
Importing archive into upstream branch...
Creating tag: 'upstream/0.4.1'
I'm happy.  You should be too.

==> git-bloom-generate -y rosrelease rolling --source upstream -i 1
Releasing package: ['tracetools_acceleration']
Releasing package 'tracetools_acceleration' for 'rolling' to: 'release/rolling/tracetools_acceleration'

==> git-bloom-generate -y rosdebian --prefix release/rolling rolling -i 1 --os-name ubuntu
Generating source debs for the packages: ['tracetools_acceleration']
Debian Incremental Version: 1
Debian Distributions: ['jammy']
Releasing for rosdistro: rolling

Pre-verifying Debian dependency keys...
Running 'rosdep update'...
All keys are OK

Placing debian template files into 'debian/rolling/tracetools_acceleration' branch.
==> Placing templates files in the 'debian' folder.

####
#### Generating 'jammy' debian for package 'tracetools_acceleration' at version '0.4.1-1'
####
Generating debian for jammy...
No homepage set, defaulting to ''

A CHANGELOG.rst was found, but no changelog for this version was found.
You REALLY should have a entry (even a blank one) for each version of your package.

Package 'tracetools-acceleration' has dependencies:
Build and Build Tool Dependencies:
  rosdep key           => jammy key
  ament_cmake_ros      => ['ros-rolling-ament-cmake-ros']
  pkg-config           => ['pkg-config']
  ament_lint_auto      => ['ros-rolling-ament-lint-auto']
  ament_lint_common    => ['ros-rolling-ament-lint-common']
ROS Distro index file associate with commit '725def91e71e2e1a9520416feb916c802ed75314'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/725def91e71e2e1a9520416feb916c802ed75314/index-v4.yaml'
==> In place processing templates in 'debian' folder.
Expanding 'debian/gbp.conf.em' -> 'debian/gbp.conf'
Expanding 'debian/source/options.em' -> 'debian/source/options'
Expanding 'debian/source/format.em' -> 'debian/source/format'
Expanding 'debian/control.em' -> 'debian/control'
Expanding 'debian/copyright.em' -> 'debian/copyright'
Expanding 'debian/compat.em' -> 'debian/compat'
Expanding 'debian/rules.em' -> 'debian/rules'
Expanding 'debian/changelog.em' -> 'debian/changelog'
Creating tag: debian/ros-rolling-tracetools-acceleration_0.4.1-1_jammy
####
#### Successfully generated 'jammy' debian for package 'tracetools_acceleration' at version '0.4.1-1'
####


==> git-bloom-generate -y rosdebian --prefix release/rolling rolling -i 1 --os-name debian --os-not-required
Generating source debs for the packages: ['tracetools_acceleration']
Debian Incremental Version: 1
Debian Distributions: ['bullseye']
Releasing for rosdistro: rolling

Pre-verifying Debian dependency keys...
Running 'rosdep update'...
All keys are OK

Placing debian template files into 'debian/rolling/tracetools_acceleration' branch.
==> Placing templates files in the 'debian' folder.

####
#### Generating 'bullseye' debian for package 'tracetools_acceleration' at version '0.4.1-1'
####
Generating debian for bullseye...
No homepage set, defaulting to ''

A CHANGELOG.rst was found, but no changelog for this version was found.
You REALLY should have a entry (even a blank one) for each version of your package.

Package 'tracetools-acceleration' has dependencies:
Build and Build Tool Dependencies:
  rosdep key           => bullseye key
  ament_cmake_ros      => ['ros-rolling-ament-cmake-ros']
  pkg-config           => ['pkg-config']
  ament_lint_auto      => ['ros-rolling-ament-lint-auto']
  ament_lint_common    => ['ros-rolling-ament-lint-common']
ROS Distro index file associate with commit '725def91e71e2e1a9520416feb916c802ed75314'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/725def91e71e2e1a9520416feb916c802ed75314/index-v4.yaml'
==> In place processing templates in 'debian' folder.
Expanding 'debian/gbp.conf.em' -> 'debian/gbp.conf'
Expanding 'debian/source/options.em' -> 'debian/source/options'
Expanding 'debian/source/format.em' -> 'debian/source/format'
Expanding 'debian/control.em' -> 'debian/control'
Expanding 'debian/copyright.em' -> 'debian/copyright'
Expanding 'debian/compat.em' -> 'debian/compat'
Expanding 'debian/rules.em' -> 'debian/rules'
Expanding 'debian/changelog.em' -> 'debian/changelog'
Creating tag: debian/ros-rolling-tracetools-acceleration_0.4.1-1_bullseye
####
#### Successfully generated 'bullseye' debian for package 'tracetools_acceleration' at version '0.4.1-1'
####


==> git-bloom-generate -y rosrpm --prefix release/rolling rolling -i 1 --os-name fedora
No platforms defined for os 'fedora' in release file for the 'rolling' distro.
Not performing RPM generation.

==> git-bloom-generate -y rosrpm --prefix release/rolling rolling -i 1 --os-name rhel
Generating source RPMs for the packages: ['tracetools_acceleration']
RPM Incremental Version: 1
RPM OS: rhel
RPM Distributions: ['8']
Releasing for rosdistro: rolling

Pre-verifying RPM dependency keys...
Running 'rosdep update'...
All keys are OK

Placing RPM template files into 'rpm/rolling/tracetools_acceleration' branch.
==> Placing templates files in the 'rpm' folder.

####
#### Generating 'rhel 8' RPM for package 'tracetools_acceleration' at version '0.4.1-1'
####
Generating RPM for rhel 8...
No homepage set
Package 'tracetools-acceleration' has dependencies:
Build and Build Tool Dependencies:
  rosdep key           => rhel 8 key
  ament_cmake_ros      => ['ros-rolling-ament-cmake-ros']
  pkg-config           => ['pkgconfig']
  ament_lint_auto      => ['ros-rolling-ament-lint-auto']
  ament_lint_common    => ['ros-rolling-ament-lint-common']
ROS Distro index file associate with commit '725def91e71e2e1a9520416feb916c802ed75314'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/725def91e71e2e1a9520416feb916c802ed75314/index-v4.yaml'
==> In place processing templates in 'rpm' folder.
Expanding 'rpm/template.spec.em' -> 'rpm/template.spec'
Creating tag: rpm/ros-rolling-tracetools-acceleration-0.4.1-1_8
####
#### Successfully generated 'rhel 8' RPM for package 'tracetools_acceleration' at version '0.4.1-1'
####





Tip: Check to ensure that the debian tags created have the same version as the upstream version you are releasing.
Everything went as expected, you should check that the new tags match your expectations, and then push to the release repo with:
  git push --all && git push --tags  # You might have to add --force to the second command if you are over-writing existing tags
<== Released 'tracetools_acceleration' using release track 'rolling' successfully
==> git remote -v
origin	https://github.com/ros2-gbp/tracetools_acceleration-release.git (fetch)
origin	https://github.com/ros2-gbp/tracetools_acceleration-release.git (push)
Releasing complete, push to release repository?
Continue [Y/n]? Y
==> Pushing changes to release repository for 'tracetools_acceleration'
==> git push --all
Enumerating objects: 169, done.
Counting objects: 100% (155/155), done.
Delta compression using up to 12 threads
Compressing objects: 100% (112/112), done.
Writing objects: 100% (121/121), 13.51 KiB | 6.75 MiB/s, done.
Total 121 (delta 45), reused 10 (delta 7)
remote: Resolving deltas: 100% (45/45), completed with 14 local objects.
To https://github.com/ros2-gbp/tracetools_acceleration-release.git
   8cac4b8..29cce62  debian/rolling/bullseye/tracetools_acceleration -> debian/rolling/bullseye/tracetools_acceleration
   621a684..a5b0a98  debian/rolling/jammy/tracetools_acceleration -> debian/rolling/jammy/tracetools_acceleration
   5d1fe19..1e2adac  debian/rolling/tracetools_acceleration -> debian/rolling/tracetools_acceleration
   cc7c2e0..2041f73  master -> master
   d4d8f32..ea38699  patches/debian/rolling/bullseye/tracetools_acceleration -> patches/debian/rolling/bullseye/tracetools_acceleration
   476f0bd..2286ac7  patches/debian/rolling/jammy/tracetools_acceleration -> patches/debian/rolling/jammy/tracetools_acceleration
   bc5b41a..0ab0967  patches/debian/rolling/tracetools_acceleration -> patches/debian/rolling/tracetools_acceleration
   c4e528a..fb56b72  patches/release/rolling/tracetools_acceleration -> patches/release/rolling/tracetools_acceleration
   0512210..c556f79  patches/rpm/rolling/8/tracetools_acceleration -> patches/rpm/rolling/8/tracetools_acceleration
   d61e8a0..f6a6da5  patches/rpm/rolling/tracetools_acceleration -> patches/rpm/rolling/tracetools_acceleration
   3829900..ae8e990  release/rolling/tracetools_acceleration -> release/rolling/tracetools_acceleration
   bd9f4af..2fd7c4d  rpm/rolling/8/tracetools_acceleration -> rpm/rolling/8/tracetools_acceleration
   2afe210..75ce1dc  rpm/rolling/tracetools_acceleration -> rpm/rolling/tracetools_acceleration
   8f1201c..eb4cb09  upstream -> upstream
<== Pushed changes successfully
==> Pushing tags to release repository for 'tracetools_acceleration'
==> git push --tags
Total 0 (delta 0), reused 0 (delta 0)
To https://github.com/ros2-gbp/tracetools_acceleration-release.git
 * [new tag]         debian/ros-rolling-tracetools-acceleration_0.4.1-1_bullseye -> debian/ros-rolling-tracetools-acceleration_0.4.1-1_bullseye
 * [new tag]         debian/ros-rolling-tracetools-acceleration_0.4.1-1_jammy -> debian/ros-rolling-tracetools-acceleration_0.4.1-1_jammy
 * [new tag]         release/rolling/tracetools_acceleration/0.4.1-1 -> release/rolling/tracetools_acceleration/0.4.1-1
 * [new tag]         rpm/ros-rolling-tracetools-acceleration-0.4.1-1_8 -> rpm/ros-rolling-tracetools-acceleration-0.4.1-1_8
 * [new tag]         upstream/0.4.1 -> upstream/0.4.1
<== Pushed tags successfully
==> Generating pull request to distro file located at 'https://raw.githubusercontent.com/ros/rosdistro/725def91e71e2e1a9520416feb916c802ed75314/rolling/distribution.yaml'
Would you like to add documentation information for this repository? [Y/n]? Y
==> Looking for a doc entry for this repository in a different distribution...
No existing doc entries found for use as defaults.
Please enter your repository information for the doc generation job.
This information should point to the repository from which documentation should be generated.
VCS Type must be one of git, svn, hg, or bzr.
VCS type: git
VCS url: https://github.com/ros-acceleration/tracetools_acceleration.git
VCS version must be a branch, tag, or commit, e.g. master or 0.1.0
VCS version: main
Would you like to add source information for this repository? [Y/n]? Y
==> Looking for a source entry for this repository in a different distribution...
No existing source entries found for use as defaults.
Please enter information which points to the active development branch for this repository.
This information is used to run continuous integration jobs and for developers to checkout from.
VCS Type must be one of git, svn, hg, or bzr.
VCS type: git
VCS url: https://github.com/ros-acceleration/tracetools_acceleration.git
VCS version must be a branch, tag, or commit, e.g. master or 0.1.0
VCS version: main
Since you are on github we can add a job to run your tests on each pull request.If you would like to turn this on please see http://wiki.ros.org/buildfarm/Pull%20request%20testing for more information. There is more setup required to setup the hooks correctly.
Would you like to turn on pull request testing? [y/N]? y
Would you like to add a maintenance status for this repository? [Y/n]? Y
Please enter a maintenance status.
Valid maintenance statuses:
- developed: active development is in progress
- maintained: no new development, but bug fixes and pull requests are addressed
- unmaintained: looking for new maintainer, bug fixes and pull requests will not be addressed
- end-of-life: should not be used, will disappear at some point
Status: developed
You can also enter a status description.
This is usually reserved for giving a reason when a status is 'end-of-life'.
Status Description [press Enter for no change]:
Unified diff for the ROS distro file located at '/tmp/tmpdjhjp0wl/tracetools_acceleration-0.4.1-1.patch':
--- 725def91e71e2e1a9520416feb916c802ed75314/rolling/distribution.yaml
+++ 725def91e71e2e1a9520416feb916c802ed75314/rolling/distribution.yaml
@@ -4709,6 +4709,22 @@
       url: https://github.com/ros-tooling/topic_tools.git
       version: main
     status: developed
+  tracetools_acceleration:
+    doc:
+      type: git
+      url: https://github.com/ros-acceleration/tracetools_acceleration.git
+      version: main
+    release:
+      tags:
+        release: release/rolling/{package}/{version}
+      url: https://github.com/ros2-gbp/tracetools_acceleration-release.git
+      version: 0.4.1-1
+    source:
+      test_pull_requests: true
+      type: git
+      url: https://github.com/ros-acceleration/tracetools_acceleration.git
+      version: main
+    status: developed
   tracetools_analysis:
     doc:
       type: git
==> Checking on GitHub for a fork to make the pull request from...
==> Using this fork to make a pull request from: vmayoral/rosdistro
==> Cloning vmayoral/rosdistro...
==> mkdir -p rosdistro
==> git init
Initialized empty Git repository in /tmp/9fpxz_eo/rosdistro/.git/
Pull Request Title: tracetools_acceleration: 0.4.1-1 in 'rolling/distribution.yaml' [bloom]
Pull Request Body :
Increasing version of package(s) in repository `tracetools_acceleration` to `0.4.1-1`:

- upstream repository: https://github.com/ros-acceleration/tracetools_acceleration.git
- release repository: https://github.com/ros2-gbp/tracetools_acceleration-release.git
- distro file: `rolling/distribution.yaml`
- bloom version: `0.10.7`
- previous version for package: `null`

Open a pull request from 'vmayoral/rosdistro:bloom-tracetools_acceleration-0' into 'ros/rosdistro:master'?
Continue [Y/n]? Y
==> git checkout -b bloom-tracetools_acceleration-0
Switched to a new branch 'bloom-tracetools_acceleration-0'
==> Pulling latest rosdistro branch
remote: Enumerating objects: 170051, done.
remote: Counting objects: 100% (86/86), done.
remote: Compressing objects: 100% (26/26), done.
remote: Total 170051 (delta 41), reused 83 (delta 39), pack-reused 169965
Receiving objects: 100% (170051/170051), 104.88 MiB | 5.15 MiB/s, done.
Resolving deltas: 100% (101954/101954), done.
From https://github.com/ros/rosdistro
 * branch            master     -> FETCH_HEAD
==> git reset --hard 725def91e71e2e1a9520416feb916c802ed75314
HEAD is now at 725def91e Retarget ament_acceleration repos to rolling branch (#32587)
==> Writing new distribution file: rolling/distribution.yaml
==> git add rolling/distribution.yaml
==> git commit -m "tracetools_acceleration: 0.4.1-1 in 'rolling/distribution.yaml' [bloom]"
[bloom-tracetools_acceleration-0 06060cd81] tracetools_acceleration: 0.4.1-1 in 'rolling/distribution.yaml' [bloom]
 1 file changed, 16 insertions(+)
==> Pushing changes to fork
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 12 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (4/4), 470 bytes | 470.00 KiB/s, done.
Total 4 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote:
remote: Create a pull request for 'bloom-tracetools_acceleration-0' on GitHub by visiting:
remote:      https://github.com/vmayoral/rosdistro/pull/new/bloom-tracetools_acceleration-0
remote:
To https://github.com/vmayoral/rosdistro.git
 * [new branch]          bloom-tracetools_acceleration-0 -> bloom-tracetools_acceleration-0
<== Pull request opened at: https://github.com/ros/rosdistro/pull/32592

PR submitted to rosdistro: ros/rosdistro#32592

@methylDragon
Copy link
Contributor Author

methylDragon commented Mar 30, 2022

You'll want to be targeting the rolling branch here for the devel branch!

You should:

  • Go into the PR and update all instances of version: main to version: rolling,
  • And also update the repo's tracks.yaml's devel_branch: null to devel_branch: rolling

I'll leave this one to you, I'll bloom the rest (though vitis_common will have to wait for the merge of ament_vitis)

@methylDragon methylDragon changed the title Release Process! (PENDING PR MERGE) Release Process! (PENDING ROSDISTRO MERGE - CHANGES IN PR NEEDED) Mar 30, 2022
@methylDragon
Copy link
Contributor Author

I'll update the branches since it got merged in.
ros/rosdistro#32592

@methylDragon
Copy link
Contributor Author

@methylDragon methylDragon changed the title Release Process! (PENDING ROSDISTRO MERGE - CHANGES IN PR NEEDED) Release Process! (RELEASED - Monitor Buildfarm) 🟡 Apr 1, 2022
@methylDragon
Copy link
Contributor Author

Branch retarget merged!

@methylDragon methylDragon changed the title Release Process! (RELEASED - Monitor Buildfarm) 🟡 Release Process! (RELEASED - Pending Sync) 🟢 Apr 1, 2022
@methylDragon methylDragon changed the title Release Process! (RELEASED - Pending Sync) 🟢 Release Process! (LIVE ON JAMMY) 🟢 🍯 Apr 14, 2022
@methylDragon methylDragon changed the title Release Process! (LIVE ON JAMMY) 🟢 🍯 Release Process! (ROLLING LIVE ON JAMMY) 🟢 🍯 Apr 14, 2022
@methylDragon
Copy link
Contributor Author

Closing this issue, since we're done 🎉
Congratulations on the press release too!

Repository owner moved this from In Progress to Done in ROS 2 Hardware Acceleration WG backlog May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants