Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone version of LPF #222

Merged
merged 10 commits into from
Nov 6, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 4, 2024

Replaces #192 and closes #164

Changes on top:

  • I changed the base class to be independent of filters
  • Used the old class/file name and moved the new one to control_toolbox namespace.

The filter plugins should still work as before without any changes (see the test files).

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 70.78652% with 26 lines in your changes missing coverage. Please review.

Project coverage is 51.17%. Comparing base (e05102c) to head (b85a21d).
Report is 1 commits behind head on ros2-master.

Files with missing lines Patch % Lines
include/control_filters/low_pass_filter_ros.hpp 60.00% 12 Missing and 4 partials ⚠️
include/control_toolbox/low_pass_filter.hpp 79.59% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           ros2-master     #222      +/-   ##
===============================================
+ Coverage        50.41%   51.17%   +0.76%     
===============================================
  Files                9       10       +1     
  Lines              486      510      +24     
  Branches            62       66       +4     
===============================================
+ Hits               245      261      +16     
- Misses             215      221       +6     
- Partials            26       28       +2     
Flag Coverage Δ
unittests 51.17% <70.78%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/control_toolbox/low_pass_filter.hpp 79.59% <79.59%> (ø)
include/control_filters/low_pass_filter_ros.hpp 60.00% <60.00%> (ø)

@christophfroehlich
Copy link
Contributor Author

@roncapat what do you think?

@roncapat
Copy link
Contributor

roncapat commented Nov 6, 2024

@roncapat what do you think?

Nice for me! Thank you 👍🏻

@christophfroehlich christophfroehlich merged commit 7d008a4 into ros2-master Nov 6, 2024
26 checks passed
@christophfroehlich christophfroehlich deleted the roncapat/ros2-master branch November 6, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LowPassFilter accepts parameters only from node
4 participants