Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job for clang build #239

Merged
merged 7 commits into from
Dec 7, 2024
Merged

Add job for clang build #239

merged 7 commits into from
Dec 7, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 25, 2024

See ros-controls/realtime_tools#207

clang was complaining about implicit conversions in the PID class.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.78%. Comparing base (93955a8) to head (483a788).

Files with missing lines Patch % Lines
include/control_toolbox/low_pass_filter.hpp 0.00% 0 Missing and 1 partial ⚠️
src/pid_ros.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #239   +/-   ##
============================================
  Coverage        74.78%   74.78%           
============================================
  Files               22       22           
  Lines             1071     1071           
  Branches            85       85           
============================================
  Hits               801      801           
  Misses             222      222           
  Partials            48       48           
Flag Coverage Δ
unittests 74.78% <93.93%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/pid_tests.cpp 100.00% <100.00%> (ø)
include/control_toolbox/low_pass_filter.hpp 76.19% <0.00%> (ø)
src/pid_ros.cpp 72.41% <50.00%> (ø)

@christophfroehlich christophfroehlich changed the title Add job for clang build and fix PID Add job for clang build Dec 7, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. The clang job seem to fail due to the implicit conversions in the tests

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@christophfroehlich christophfroehlich merged commit d9b72de into ros2-master Dec 7, 2024
27 checks passed
@christophfroehlich christophfroehlich deleted the ci/clang branch December 7, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants