-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job for clang build #239
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #239 +/- ##
============================================
Coverage 74.78% 74.78%
============================================
Files 22 22
Lines 1071 1071
Branches 85 85
============================================
Hits 801 801
Misses 222 222
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c2431d0
to
3dd32fd
Compare
3dd32fd
to
8273971
Compare
8273971
to
814ade3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. The clang job seem to fail due to the implicit conversions in the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect!
See ros-controls/realtime_tools#207
clang was complaining about implicit conversions in the PID class.