Allow to get thread handle in RealtimePublisher
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
christophfroehlich,
homalozoa,
mamueluth,
moriarty,
peterdavidfagan and
saikishor
firesurfer
reviewed
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 73.16% 73.16%
=======================================
Files 7 7
Lines 436 436
Branches 72 72
=======================================
Hits 319 319
Misses 73 73
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
requested changes
Dec 9, 2024
roncapat
commented
Dec 9, 2024
roncapat
commented
Dec 10, 2024
roncapat
commented
Dec 10, 2024
|
@roncapat Can you please fix the pre-commit? |
roncapat
changed the title
RealtimePublisher (via inheritance)RealtimePublisher
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
github-actions
bot
requested review from
bmagyar,
LukasMacha97,
mcbed,
progtologist,
qiayuanl,
saikishor and
VX792
firesurfer
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
I think the argument from @saikishor is true. Inheriting would be cubersome. Let's just expose it like this.
christophfroehlich
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to close #176 as suggested by @firesurfer.