Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noetic release? #48

Closed
mikeferguson opened this issue Jun 2, 2020 · 4 comments
Closed

Noetic release? #48

mikeferguson opened this issue Jun 2, 2020 · 4 comments
Assignees
@130s

Comments

@mikeferguson
Copy link
Member

Posting this publicly (although I already communicated it to @130s) - I've tested this as a source build in Noetic, all looks to be working. The only change that will be needed is to bump the first line of CMakeLists.txt to:

cmake_minimum_required(VERSION 3.0.2)

But this only supports Kinetic+ - so not sure if you want to create a new branch for that.
@130s 130s self-assigned this Jun 2, 2020
@130s 130s mentioned this issue Jun 2, 2020
Merged
1 task
@130s
Copy link
Member

130s commented Jun 3, 2020 •
edited
Loading

bloom keeps failing on 2 of my laptops.

$ bloom-release --rosdistro noetic --track noetic rgbd_launch -p
:
Created 'noetic' track.
==> Generating pull request to distro file located at 'https://raw.githubusercontent.com/ros/rosdistro/master/noetic/distribution.yaml'
Failed to open pull request: KeyError - u'last_version'

$ bloom-release --version
0.9.7

@130s
Copy link
Member

130s commented Jun 3, 2020

Moved forward with bloom but still got stuck at opening a PR:

$ bloom-release --rosdistro noetic --track noetic rgbd_launch --edit
:

+    status: maintained
+  rgbd_launch:
+    doc:
+      type: git
+      url: https://github.com/ros-drivers/rgbd_launch.git
+      version: noetic-devel
+    release:
+      tags:
+        release: release/noetic/{package}/{version}
+      url: https://github.com/ros-gbp/rgbd_launch-release.git
+      version: 2.3.0-1
+    source:
+      type: git
+      url: https://github.com/ros-drivers/rgbd_launch.git
+      version: noetic-devel
     status: maintained
   robot_navigation:
     doc:
==> Checking on GitHub for a fork to make the pull request from...
Could not find a fork of ros/rosdistro on the 130s GitHub account.
Would you like to create one now?
Continue [Y/n]? 
Aborting pull request: HTTP Error 401: Unauthorized (https://api.github.com/repos/ros/rosdistro/forks)
The release of your packages was successful, but the pull request failed.
Please manually open a pull request by editing the file here: 'https://raw.githubusercontent.com/ros/rosdistro/master/noetic/distribution.yaml'
<== No pull request opened.

130s added a commit to 130s/rosdistro that referenced this issue Jun 3, 2020
@130s
[noetic] rgbd_launch 2.3.0
adfdefe 
Increasing version of package(s) in repository `rgbd_launch` to `2.3.0`:

- upstream repository: https://github.com/ros-drivers/rgbd_launch.git
- release repository: https://github.com/ros-gbp/rgbd_launch-release.git
- distro file: `noetic/distribution.yaml`
- bloom version: `0.9.7`, but PR is made manually due to ros-drivers/rgbd_launch#48 (comment)
- previous version for package: None
@130s 130s mentioned this issue Jun 3, 2020
Merged
@130s
Copy link
Member

130s commented Jun 3, 2020

Manually opened PR ros/rosdistro#25278

sloretz pushed a commit to ros/rosdistro that referenced this issue Jun 3, 2020
@130s
[noetic] rgbd_launch 2.3.0 (#25278)
fe2d960 
Increasing version of package(s) in repository `rgbd_launch` to `2.3.0`:

- upstream repository: https://github.com/ros-drivers/rgbd_launch.git
- release repository: https://github.com/ros-gbp/rgbd_launch-release.git
- distro file: `noetic/distribution.yaml`
- bloom version: `0.9.7`, but PR is made manually due to ros-drivers/rgbd_launch#48 (comment)
- previous version for package: None
@130s
Copy link
Member

130s commented Jun 3, 2020

Done ros/rosdistro#25278

@130s 130s closed this as completed Jun 3, 2020
@130s 130s mentioned this issue Jun 3, 2020
Merged
clalancette pushed a commit to ros/rosdistro that referenced this issue Jun 8, 2020
@130s
openni2_camera: 1.4.2-1 in 'noetic distribution.yaml' [semi-bloom] (#…
91cb085 
…25305)

Increasing version of package(s) in repository openni2_camera 1.4.2

- upstream repository: https://github.com/ros-drivers/openni2_camera.git
- release repository: https://github.com/ros-gbp/openni2_camera-release.git
- distro file: `noetic/distribution.yaml`
- bloom version: `0.9.7`, but PR is made manually due to a similar/the same issue as similar to ros-drivers/rgbd_launch#48 (comment)
- previous version for package: None
sloretz pushed a commit to ros/rosdistro that referenced this issue Aug 5, 2020
@130s @sloretz
[noetic] rgbd_launch 2.3.0 (#25278)
0ec4035 
Increasing version of package(s) in repository `rgbd_launch` to `2.3.0`:

- upstream repository: https://github.com/ros-drivers/rgbd_launch.git
- release repository: https://github.com/ros-gbp/rgbd_launch-release.git
- distro file: `noetic/distribution.yaml`
- bloom version: `0.9.7`, but PR is made manually due to ros-drivers/rgbd_launch#48 (comment)
- previous version for package: None
sloretz pushed a commit to ros/rosdistro that referenced this issue Aug 5, 2020
@130s @sloretz
openni2_camera: 1.4.2-1 in 'noetic distribution.yaml' [semi-bloom] (#…
1f92398 
…25305)

Increasing version of package(s) in repository openni2_camera 1.4.2

- upstream repository: https://github.com/ros-drivers/openni2_camera.git
- release repository: https://github.com/ros-gbp/openni2_camera-release.git
- distro file: `noetic/distribution.yaml`
- bloom version: `0.9.7`, but PR is made manually due to a similar/the same issue as similar to ros-drivers/rgbd_launch#48 (comment)
- previous version for package: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@130s 130s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeferguson @130s