spinOnce timeout at 5ms

[1r0b1n0]

Hi,
While browsing the code I stumbled on this line that seems like a bug :

rosserial/rosserial_client/src/ros_lib/ros/node_handle.h

Line 215 in 2f18dfa

else if( hardware_.time() - c_time > (SYNC_SECONDS)){

This means that the communication could be reset if we spent more than 5ms processing previous data (callbacks included).
Shouldn't it be something like 5s :
else if( hardware_.time() - c_time > (SYNC_SECONDS*1000)){ ?

[mikepurvis]

Indeed, this is a units comparison failure! Thanks for the catch— do you mind submitting a PR to correct the issue?

FYI @mikeodr

[supercrazysam]

@mikepurvis may I ask what would be a reasonable value to set the spin_timeout?