Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD_PKGS_BLACKLIST? #172

Closed
gavanderhoorn opened this issue May 7, 2017 · 7 comments
Closed

Add BUILD_PKGS_BLACKLIST? #172

gavanderhoorn opened this issue May 7, 2017 · 7 comments

Comments

@gavanderhoorn
Copy link
Member

This would be the opposite of BUILD_PKGS_WHITELIST.

Example use-case: motoman_experimental depends on industrial_experimental, for a single package only: industrial_robot_pkg_gen. As industrial_experimental has not been released, I'm using a .travis.rosinstall file. Everything works, but: industrial_experimental also contains IRC_v2 packages, which run a lot of tests.

Testing is good, but motoman_experimental does not use anything from IRCv2, and I'd rather ignore the IRCv2 packages completely in the Travis runs for motoman_experimental.

Instead of having to list each and every pkg I do want tested, it would be nice if we could invert the setting and use a blacklist.

@mathias-luedtke
Copy link
Member

mathias-luedtke commented May 7, 2017

I have started to implemented this (and other features) in #137

@gavanderhoorn
Copy link
Member Author

Ok, nice.

Would you want to keep this one open then, and close after implementation / merge of #137, or close right now as a sort-of duplicate?

@mathias-luedtke
Copy link
Member

Would you want to keep this one open

Let's keep it open as a reminder

and I'd rather ignore the IRCv2 packages completely in the Travis runs for motoman_experimental.

As a temporary fix you could create a CATKIN_IGNORE file in BEFORE_SCRIPT or run catkin config .. to blacklist it

@gavanderhoorn
Copy link
Member Author

gavanderhoorn commented May 7, 2017

Yeah, I tried to do that, but forgot that the .rosinstall file only gets processed by travis.sh itself. So my line added before travis.sh under script didn't work as I intended.

Does BEFORE_SCRIPT only work with actual scripts, or would a single script line (ie: touch ..) also work?

@mathias-luedtke
Copy link
Member

Does BEFORE_SCRIPT only work with actual scripts, or would a single script line (ie: touch ..) also work?

The string gets executed by bash -c, so touch ... works

@130s
Copy link
Member

130s commented Dec 11, 2018

Does BEFORE_SCRIPT only work with actual scripts, or would a single script line (ie: touch ..) also work?

The string gets executed by bash -c, so touch ... works

If I'm not mistaken, target repo is read-only so you can't touch into it (there fore something like #123 is useful)?

@mathias-luedtke
Copy link
Member

BUILD_PKGS_WHITELIST was removed in #361 in favor of the new workspace management, which only supports "black-listing" by removing directories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants