Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin Parameter to Overcome Numerical Issues #27

Open
jayalatn opened this issue Jul 8, 2020 · 4 comments
Open

Margin Parameter to Overcome Numerical Issues #27

jayalatn opened this issue Jul 8, 2020 · 4 comments

Comments

@jayalatn
Copy link

jayalatn commented Jul 8, 2020

Because of floating point number accuracy, sometimes, the state.satisfiesBounds(group) fails in the stomp_planner.cpp. Currently, there is no external way (via the configuration file) to set a margin for satisfiesBounds(group, margin). Can we add this feature and what is the best way to add it unless via config file?

@jrgnicho
Copy link
Member

jrgnicho commented Jul 8, 2020

If we don't expect this margin value to change we could set it up as a global const variable with a very small value

@jayalatn
Copy link
Author

Yes that would be sufficient for now if configurable parameter is a hassle. I can implement one of the other if we can create a ticket for this.

@jrgnicho
Copy link
Member

@jayalatn feel free to create a PR with the global const variable

@jayalatn
Copy link
Author

will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants