Add get_package_condition_context function #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function captures package condition context variables for use when resolving conditions in package manifests. This function is currently implemented in ros_buildfarm, but is useful in other contexts as well.
|
Looks good. I implemented something similar in colcon-distro to correctly handle chimera packages like plotjuggler, where the same source branches are being built for ROS 1 and 2 distributions. |
Thanks for the feedback. GitHub reviews are always welcome on the infrastructure team, even if the check mark isn't green :) |
mikepurvis
approved these changes
May 29, 2024
nuclearsandwich
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function captures package condition context variables for use when resolving conditions in package manifests. This function is currently implemented in ros_buildfarm, but is useful in other contexts as well.