-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alpine linux detection #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I can confirm in your environment that I can reproduce this issue.
>>> detect.get_codename()
u'3.8.0'
>>> dir(detect)
['__class__', '__delattr__', '__dict__', '__doc__', '__format__', '__getattribute__', '__hash__', '__init__', '__module__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', 'get_codename', 'get_version', 'is_os', 'release_info']
>>> detect.release_info()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'dict' object is not callable
>>> detect.release_info
{u'NAME': u'Alpine Linux', u'VERSION_ID': u'3.8.0', u'BUG_REPORT_URL': u'http://bugs.alpinelinux.org', u'PRETTY_NAME': u'Alpine Linux v3.8', u'HOME_URL': u'http://alpinelinux.org', u'ID': u'alpine'}
>>>
The ID is 'alpine' and FDODetect logic is checking the ID: https://github.com/at-wat/rospkg/blob/b55f212eb672dba1a324037bad4db6814acbd226/src/rospkg/os_detect.py#L179
@Minipada Can you check if this is working for you?
You're totally right. I also just checked, the name field was filled instead of the ID |
With ros-infrastructure/rospkg#148 and ros-infrastructure/rosdep#616, ros_core is ready to be built on Alpine Linux (edge version)
With ros-infrastructure/rospkg#148 and ros-infrastructure/rosdep#616, ros_core can be built from source on Alpine Linux (edge version)
With ros-infrastructure/rospkg#148 and ros-infrastructure/rosdep#616, All packages required by ros_core can be installed by rosdep on Alpine Linux (edge version)
With ros-infrastructure/rospkg#148 and ros-infrastructure/rosdep#616, all packages required by ros_core can be installed by rosdep on Alpine Linux (edge version)
* Add minimal alpine rosdeps for ros_core With ros-infrastructure/rospkg#148 and ros-infrastructure/rosdep#616, all packages required by ros_core can be installed by rosdep on Alpine Linux (edge version) * Use apk gtest and src gmock * Use libressl instead of openssl since Alpine Linux recommends to use libressl instead of openssl (https://bugs.alpinelinux.org/issues/4970) * Fix to use python2-dev instead of python2
This PR fixes OS detection on Alpine Linux.
rosdep update
failed on Alpine showing an error pasted below.FdoDetect
checks ID field in/etc/os-release
(which is defined as "alpine") andFdoDetect
was constructed with ID of "Alpine Linux".I'm trying to add alpine support to rosdep and rosdistro.
A working demo to install dependent package on alpine using
rosdep
is placed at https://github.com/at-wat/alpine-ros.FYI: @Minipada
ref: #137