Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom Docker class with upstream docker library #66

Closed
tfoote opened this issue Aug 17, 2017 · 2 comments
Closed

Replace custom Docker class with upstream docker library #66

tfoote opened this issue Aug 17, 2017 · 2 comments
Assignees
@allenh1
Labels
enhancement in review

Comments

@tfoote
Copy link
Member

tfoote commented Aug 17, 2017

There's a docker python module that implements run etc.

https://pypi.python.org/pypi/docker

Reusing the upstream module will likely be more robust in the long term. However, note that there are some very different versions available currently on common platforms. And a large API change in version 2.0
@allenh1
Copy link
Contributor

allenh1 commented Aug 17, 2017

Reusing the upstream module will likely be more robust in the long term.

Sounds like a good idea to me!

@allenh1 allenh1 added the ready label Aug 17, 2017
@allenh1 allenh1 self-assigned this Aug 17, 2017
@allenh1 allenh1 added in progress and removed ready labels Oct 16, 2017
@allenh1 allenh1 mentioned this issue Oct 17, 2017
Merged
@allenh1
Copy link
Contributor

allenh1 commented Oct 18, 2017

@tfoote PR is up! I just swapped out the subprocess calls to use the sdk.

@allenh1 allenh1 closed this as completed Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allenh1 allenh1

Labels
enhancement in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfoote @allenh1