Build failing on melodic

[mkhansenbot]

Is this package supported on melodic? I'm trying to build and getting this error.

/home/mkhansen/ros_ws/src/depthimage_to_laserscan/src/DepthImageToLaserScanNodelet.cpp:60:24: error: expected constructor, destructor, or type conversion before ‘(’ token
PLUGINLIB_DECLARE_CLASS(depthimage_to_laserscan, DepthImageToLaserScanNodelet, depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);
^
Has anyone built it for melodic?

[mikaelarguedas]

I think you need to use #27 for it to work on melodic and it hasn't been merged or released yet.

[mkhansenbot]

@mikaelarguedas - thanks for the pointer. I pulled your patch and it built for me. Can we get that merged?

[mikaelarguedas]

Can we get that merged?

@chadrockey very gentle 🛎️

[mkhansenbot]

@dirk-thomas - can we get #27 merged so this can build on Melodic?

[chadrockey]

Sorry all, I uncovered this and took care of it.
ros/rosdistro#20212

If anyone wants to provide more love to this package let me know and I'll promote you. Send me an email if possible, I've had too many Github emails over the years and can't keep track of things. Some might sitll be bouncing @willowgarage.com to this day... :\

[sidshete]

Replace

PLUGINLIB_DECLARE_CLASS(depthimage_to_laserscan, DepthImageToLaserScanNodelet, depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);

with

PLUGINLIB_EXPORT_CLASS(depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);

this should work!!

[sidshete]

Is this package supported on melodic? I'm trying to build and getting this error.

/home/mkhansen/ros_ws/src/depthimage_to_laserscan/src/DepthImageToLaserScanNodelet.cpp:60:24: error: expected constructor, destructor, or type conversion before ‘(’ token PLUGINLIB_DECLARE_CLASS(depthimage_to_laserscan, DepthImageToLaserScanNodelet, depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet); ^ Has anyone built it for melodic?

Replace

PLUGINLIB_DECLARE_CLASS(depthimage_to_laserscan, DepthImageToLaserScanNodelet, depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);

with

PLUGINLIB_EXPORT_CLASS(depthimage_to_laserscan::DepthImageToLaserScanNodelet, nodelet::Nodelet);

this should work!!