Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2 bloom release #370

Closed
yechun1 opened this issue Dec 7, 2018 · 6 comments
Closed

ros2 bloom release #370

yechun1 opened this issue Dec 7, 2018 · 6 comments

Comments

@yechun1
Copy link
Contributor

yechun1 commented Dec 7, 2018

@mjcarroll As image_common be released in crystal rosdistro , there should be no dependence block for ros2 image_pipeline/image_depth_proc release. I would also like to add image_depth_proc from image_pipeline in this Crystal release, but I cannot to run bloom-release for this package, sync I have no permission to create a tag on image_pipeline project. Will you please help to maintain this package's releasing?

@mjcarroll
Copy link
Contributor

I'll go ahead and create the tag, and then you can cut a release. Is it only for image_depth_proc or are the other packages in image_pipeline that need to get released?

@yechun1
Copy link
Contributor Author

yechun1 commented Dec 7, 2018

image_publisher, image_view and image_proc portings are completed, would you please help to review the PR of image_viewand image_proc, and we could have quick issue fixing.
for image_publisher, I'll try to fix TODO in it very soon.

@yechun1
Copy link
Contributor Author

yechun1 commented Dec 7, 2018

or could I use below code temporary, would you give me a suggests. thanks.

_rclcpp::Node::SharedPtr node = std::shared_ptrrclcpp::Node(this);
camera_info_manager::CameraInfoManager(node);_

this will leader invalid pointer.

@yechun1
Copy link
Contributor Author

yechun1 commented Dec 9, 2018

@mjcarroll what's the deadline for crystal, currently image_depth_proc and image_pubisher are ready for release. and we may need two more days at least to fix/review/merge image_view and image_proc next workday. If there is no time for image_view and image_proc, please help to create a tag, and I could first release depth_image_proc and image_publisher. And interate other packages for next build.

@mjcarroll
Copy link
Contributor

I went ahead a did a release of image_depth_proc and image_publisher, since they are good to go, there is no reason we can't do another release before Wednesday or so.

@yechun1
Copy link
Contributor Author

yechun1 commented Dec 18, 2018

image_pipeline has been released on ros2distro, closed this issue.

@yechun1 yechun1 closed this as completed Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants