Refactor stereo_image_proc tests #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacobperron
commented
Aug 19, 2020
jacobperron
commented
- Fixed some deprecation warnings (4543634)
- Increased test timeouts to 60 seconds (35dd2a7)
- Locally, I've observed it can take up to 40 seconds to complete one of the tests when the host is under high stress. Hopefully, this will make the tests less flaky.
- Cleanup (c051070)
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Locally, I've observed it can take up to 40 seconds to complete one of the tests when the host is under high stress. Hopefully, this will make the tests less flakey. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
@jacobperron Would you mind back-porting this to Dashing? I have seen these tests fail occasionally in CI. |
|
@JWhitleyWork I've backported the test fix in #594. I don't believe the other changes in this PR are compatible with Dashing. |
|
Thanks, @jacobperron! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.