get rid of dynamic_cast #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peci1
reviewed
May 22, 2020
src/body_operations.cpp
Outdated
| @@ -160,9 +160,11 @@ void bodies::computeBoundingSphere(const std::vector<const bodies::Body*>& bodie | |||
| unsigned int vertex_count = 0; | |||
| for (auto body : bodies) | |||
| { | |||
| const bodies::ConvexMesh* conv = dynamic_cast<const bodies::ConvexMesh*>(body); | |||
| if (!conv) | |||
| if (body->type != MESH) | |||
There was a problem hiding this comment.
First test if body != nullptr. The old check would rule such cases out, whether the suggested change would segfault.
v4hn
force-pushed
the
pr-noetic-no-dynamic-cast
branch
from
2fceb43 to
4dedda8
Compare
|
First test if `body != nullptr`.
The old check would rule such cases out, whether the suggested change would segfault.
True, I updated the patch.
I'm not perfectly happy with silently skipping nullptr's in the list,
but the patch was not meant to change behavior.
|
|
@v4hn, have you seen that your code is broken? For example, you need to use |
This library does not need RTTI as all bodies & shapes are marked with `type`. The EXPECT_TRUE in the test degenerates to true for all minimally-optimizing compilers. Replaced it with something meaningful.
v4hn
force-pushed
the
pr-noetic-no-dynamic-cast
branch
from
4dedda8 to
25d35aa
Compare
|
@v4hn, have you seen that your code is broken? For example, you need to use `type_` instead of `type`.
Actually, CI was partially just broken for this test for network issues. But yes, there was still one more namespace mistake I just fixed.
|
Codecov Report
@@ Coverage Diff @@
## noetic-devel #143 +/- ##
================================================
+ Coverage 48.01% 55.60% +7.59%
================================================
Files 11 11
Lines 1689 1721 +32
================================================
+ Hits 811 957 +146
+ Misses 878 764 -114
Continue to review full report at Codecov.
|
rhaschke
approved these changes
May 23, 2020
rhaschke
pushed a commit
to rhaschke/geometric_shapes
that referenced
this pull request
May 25, 2020
This library does not need RTTI as all bodies & shapes are marked with a `type`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library does not need RTTI as all bodies & shapes are marked with
type.The EXPECT_TRUE in the test degenerates to true for all minimally-optimizing compilers.
Replaced it with something meaningful.
should be backported to melodic.