Switched to C++11 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,8 @@ | |||
| cmake_minimum_required(VERSION 2.8.3) | |||
| project(geometric_shapes) | |||
|
|
|||
| add_compile_options(-std=c++11) | |||
There was a problem hiding this comment.
I seem to remember that add_compile_options() is a >=2.8.12 thing. Should the minimum cmake version be increased to reflect that?
There was a problem hiding this comment.
shoot you're right, i forgot to do that
davetcoleman
force-pushed
the
kinetic-devel-cpp11
branch
from
6d535c3 to
630fb02
Compare
davetcoleman
force-pushed
the
kinetic-devel-cpp11
branch
from
630fb02 to
f5210c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per moveit/moveit_core#310
Note we should setup all the PRs across moveit_* packages and merge all at once.