add operator<< for enum #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just a minor thing to support debugging
bmagyar
reviewed
Apr 6, 2018
| shapes::Shape::Shape() | ||
| namespace shapes { | ||
|
|
||
| const std::string Sphere::STRING_NAME = "sphere"; |
There was a problem hiding this comment.
How about using a static const std::map<ShapeType, std::string> ?
C++11 allows for this:
std::map <int, std::string> x {
{ 42, "foo" },
{ 3, "bar" }
};
There was a problem hiding this comment.
Sure, we can do that. But the static STRING_NAME variables are - ridiculous enough - public API, although not even virtual. So if you like to see this changed please create a melodic branch and file a request there.
I wanted to retain API here to merge into kinetic.
rhaschke
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some micro-additions && simplifications