Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartesian Path Service Should Support Revolute and Prismatic Jump Thresholds #2404

Open
amalnanavati opened this issue Oct 2, 2023 · 2 comments
Labels
enhancement New feature or request persistent Allows issues to remain open without automatic stalling and closing.

Comments

@amalnanavati
Copy link
Contributor

amalnanavati commented Oct 2, 2023

Is your feature request related to a problem? Please describe.
As it stands, moveit_msgs allows users to specify a revolute_jump_threshold and prismatic_jump_threshold in GetCartesianPath.srv. Additionally, the MoveIt2 CartesianInterpolator has the capability to check revolute/prismatic jumps (code). However, the CartesianPathService does not pass the revolute_jump_threshold or prismatic_jump_thresholdattributes from the request to the CartesianInterpolator (code), preventing people who use the ROS interface from using those attributes.

Describe the solution you'd like
This should be a one-line fix: pass req->revolue_jump_threshold and req->prismatic_jump_threshold as parameters when creating the JumpThreshold in the cartesian path service (code).

Describe alternatives you've considered
N/A

Additional context
If you are willing to backport this change, it would be great to have it in Humble :)

@amalnanavati amalnanavati added the enhancement New feature or request label Oct 2, 2023
Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Nov 17, 2023
Copy link

github-actions bot commented Jan 2, 2024

This issue was closed because it has been stalled for 45 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Jan 2, 2024
@sjahr sjahr reopened this Jan 3, 2024
@sjahr sjahr added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

No branches or pull requests

2 participants