Fix CMakeLists + package.xmls #548

mintar · 2016-12-01T16:54:22Z

This fixes compilation errors when rosjava is installed on the system.
It also removes a lot of errors reported by catkin_lint.

Fixes #537 .

spmaniato · 2016-12-01T17:45:33Z

@mintar Were there no complaints about move_base ? See this comment in #483

mintar · 2016-12-02T09:35:04Z

@spmaniato I didn't even run catkin_lint on move_base, since with this PR it compiles for me with rosjava installed. But one should definitely go through all the packages again and fix all catkin_lint errors.

Some more remarks (they may be obvious, but nevertheless):

The bug Indigo build fails when ROS java is installed #537 only occurs when rosjava is installed and navigation is checked out as a source package into the Catkin workspace you're building.
Even after applying this PR, I initially need to run catkin_make 2-3 times before it eventually succeeds due to some problems with dynamic_reconfigure. (Without this PR, it doesn't build at all.)

mintar · 2016-12-21T17:04:40Z

Ping

caicaixia · 2017-01-10T10:12:35Z

Hello, these changes haven't released yet, right? I just upgrade the ros-indigo-navigation, but the version is: 1.12.13-0trusty-20161128-101040-0800. And still have ros java problem :(

mintar · 2017-01-11T12:47:23Z

@caicaixia : No, I'm still waiting for this PR to be merged. But this bug only concerns source installs anyway, so it doesn't matter if this is released or not.

DLu

Overall, looks good. I merged things in the wrong order (see #549), so could you please merge the latest indigo-devel?

DLu · 2017-01-22T23:55:27Z

costmap_2d/CMakeLists.txt

@@ -60,8 +61,6 @@ generate_dynamic_reconfigure_options(
 catkin_package(
    INCLUDE_DIRS
        include
-        ${EIGEN_INCLUDE_DIRS}
-        ${PCL_INCLUDE_DIRS}


Why are these removed?

Because there already is a catkin_package(DEPENDS PCL Eigen). This means that PCL + Eigen are already added as dependencies for any project that depends on costmap_2d, and it's Eigen's (resp. PCL's) job to export their own include dirs. The catkin_package(INCLUDE_DIRS) should only export our own include dirs.

Removing these two lines makes the following catkin_lint error go away:

costmap_2d: CMakeLists.txt(61): error: catkin_package() exports non-package include path * You listed one or more include paths in the INCLUDE_DIRS stanza * of your catkin_package() call which are not part of your * package. If you want to export include paths of other modules, * use find_package(), find_path(), and/or find_library() and add * the dependency to the DEPENDS stanza.

mintar · 2017-01-25T11:29:13Z

I've rebased this branch onto the latest indigo-devel, so it should be good to merge.

mintar · 2017-01-25T14:09:57Z

I've just added two more commits that fix 87 out of 90 catkin_lint errors (the rest are false positives).

mikeferguson · 2017-04-16T12:13:53Z

@mintar -- could you rebase this on top of latest changes (there is a conflict) and then we can get this merged. Thanks!

This fixes compilation errors when rosjava is installed on the system. It also removes a lot of errors reported by catkin_lint. Fixes ros-planning#537 .

This fixes the following catkin_lint warning: amcl: warning: include paths 'include/amcl/map' and 'include' are ambiguous * You have used two include paths where one is a parent of the * other. Thus the same headers can be included with two different * include paths which may confuse users. It is recommended that * you keep your include paths consistent.

mintar · 2017-05-07T10:34:10Z

@mikeferguson Ok, rebased!

mintar · 2017-06-01T19:02:17Z

ping

mikeferguson · 2017-07-31T21:44:24Z

Test failures are unrelated. I'm going to squash-merge to make it easier to forward port to K+L

* Fix CMakeLists + package.xmls This fixes compilation errors when rosjava is installed on the system. It also removes a lot of errors reported by catkin_lint. Fixes #537 . * Fix more CMakeLists.txt + package.xmls * amcl: disambiguate include path This fixes the following catkin_lint warning: amcl: warning: include paths 'include/amcl/map' and 'include' are ambiguous * You have used two include paths where one is a parent of the * other. Thus the same headers can be included with two different * include paths which may confuse users. It is recommended that * you keep your include paths consistent.

Port #548 to kinetic

* Fix CMakeLists + package.xmls This fixes compilation errors when rosjava is installed on the system. It also removes a lot of errors reported by catkin_lint. Fixes #537 . * Fix more CMakeLists.txt + package.xmls * amcl: disambiguate include path This fixes the following catkin_lint warning: amcl: warning: include paths 'include/amcl/map' and 'include' are ambiguous * You have used two include paths where one is a parent of the * other. Thus the same headers can be included with two different * include paths which may confuse users. It is recommended that * you keep your include paths consistent.

Port #548 to lunar

mintar · 2017-08-01T06:58:16Z

Hooray! :-)

* Fix CMakeLists + package.xmls This fixes compilation errors when rosjava is installed on the system. It also removes a lot of errors reported by catkin_lint. Fixes ros-planning#537 . * Fix more CMakeLists.txt + package.xmls * amcl: disambiguate include path This fixes the following catkin_lint warning: amcl: warning: include paths 'include/amcl/map' and 'include' are ambiguous * You have used two include paths where one is a parent of the * other. Thus the same headers can be included with two different * include paths which may confuse users. It is recommended that * you keep your include paths consistent.

mintar mentioned this pull request Dec 1, 2016

Indigo build fails when ROS java is installed #537

Closed

DLu reviewed Jan 23, 2017

View reviewed changes

mintar force-pushed the catkin_fixes branch from 35fb9de to 7ac8072 Compare January 25, 2017 11:26

mintar added 3 commits May 7, 2017 12:24

Fix CMakeLists + package.xmls

517db77

This fixes compilation errors when rosjava is installed on the system. It also removes a lot of errors reported by catkin_lint. Fixes ros-planning#537 .

Fix more CMakeLists.txt + package.xmls

f9dcddb

mintar force-pushed the catkin_fixes branch from 1218ba3 to e3efc04 Compare May 7, 2017 10:33

mikeferguson merged commit d443c44 into ros-planning:indigo-devel Jul 31, 2017

mikeferguson mentioned this pull request Jul 31, 2017

move_base doesn't depend on move_base_msgs in its CMakeLists.txt #483

Closed

mikeferguson added a commit that referenced this pull request Aug 1, 2017

Merge pull request #595 from ros-planning/kinetic_548

408ad95

Port #548 to kinetic

mikeferguson added a commit that referenced this pull request Aug 1, 2017

Merge pull request #596 from ros-planning/lunar_548

9e3d95b

Port #548 to lunar

mintar deleted the catkin_fixes branch October 29, 2017 13:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CMakeLists + package.xmls #548

Fix CMakeLists + package.xmls #548

mintar commented Dec 1, 2016

spmaniato commented Dec 1, 2016 •

edited

Loading

mintar commented Dec 2, 2016 •

edited

Loading

mintar commented Dec 21, 2016

caicaixia commented Jan 10, 2017

mintar commented Jan 11, 2017

DLu left a comment

DLu Jan 22, 2017

mintar Jan 25, 2017

mintar commented Jan 25, 2017

mintar commented Jan 25, 2017

mikeferguson commented Apr 16, 2017

mintar commented May 7, 2017

mintar commented Jun 1, 2017

mikeferguson commented Jul 31, 2017 •

edited

Loading

mintar commented Aug 1, 2017

Fix CMakeLists + package.xmls #548

Fix CMakeLists + package.xmls #548

Conversation

mintar commented Dec 1, 2016

spmaniato commented Dec 1, 2016 • edited Loading

mintar commented Dec 2, 2016 • edited Loading

mintar commented Dec 21, 2016

caicaixia commented Jan 10, 2017

mintar commented Jan 11, 2017

DLu left a comment

Choose a reason for hiding this comment

DLu Jan 22, 2017

Choose a reason for hiding this comment

mintar Jan 25, 2017

Choose a reason for hiding this comment

mintar commented Jan 25, 2017

mintar commented Jan 25, 2017

mikeferguson commented Apr 16, 2017

mintar commented May 7, 2017

mintar commented Jun 1, 2017

mikeferguson commented Jul 31, 2017 • edited Loading

mintar commented Aug 1, 2017

spmaniato commented Dec 1, 2016 •

edited

Loading

mintar commented Dec 2, 2016 •

edited

Loading

mikeferguson commented Jul 31, 2017 •

edited

Loading