-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jade Release #318
Comments
Gazebo packages in Vivid: http://packages.ubuntu.com/search?keywords=gazebo&searchon=names&suite=all§ion=all |
We usually recommend two ways of using gazebo5 packages:
Given the nature of ROS and rosdep, I would say that we want to go with |
Well, the particular use we are describing is for a package building a plugin. But it seems more than that, we should probably have
|
I think |
Well, a package which provides just a plugin (doesn't run gazebo) would just need to build depend on In practice the packages which provide the plugins will likely also have examples and so having a run depend on Either way, I'll leave it to you guys to come up with the correct rosdep key and open a pull requests against ros/rosdistro. Thanks. |
+1, I can not imaging a valid use case right now, so we can go with only two. |
According to @wjwwood 's comment, it is possible to run_depend on EDIT: I mean this is an example package that has only a plugin and no examples, so it wouldn't need |
I just made a pull request for the rosdep keys (ros/rosdistro#8243), and made the build_depends point to |
Great, you might want to touch the change logs and then we'll need to do a release (bumping the minor version) and then do the release into Jade. |
Changelogs in 193dcbb |
I see the point, it is valid yes, but I agree with Steve, the number of use cases to use libgazebo5 instead of gazebo5 is really minimal and does not worth it to introduce complexity with another key. So my +1 to the current status. I suppose that we can add some notes about the gazebo key migration (from just gazebo to gazebo5/libgazebo5-dev) so the people coming from Indigo know well what to do to change. Maybe it also interesting to mention our Migration.md document |
Please also put it or link to it in the Jade migration page: http://wiki.ros.org/jade/Migration |
I've added some quick notes to the document. http://wiki.ros.org/jade/Migration#Gazebo_Simulator |
Thanks @j-rivero that looks awesome. |
I'm going to update it since |
I just updated the wiki page; please review: http://wiki.ros.org/jade/Migration#Gazebo_Simulator |
+1, thanks Steve |
Thanks! |
Since we can't decide on whether or not to break up
gazebo_ros_control
(#179 (comment)), I propose we release everything butgazebo_ros_control
into jade for now.I've already made a
jade-devel
branch on which I've updated the use of thegazebo
rosdep key with the newgazebo5
rosdep key: d236df8This is necessary because on Trusty the
gazebo
rosdep key is already in reference to Gazebo2. And since Jade is on Trusty as well we need a different rosdep key for Gazebo5, hencegazebo5
.@scpeters or @j-rivero we need to get an entry in the rosdep database for
gazebo5
for Trusty, Utopic, and Vivid. I looked briefly at the available gazebo packages in Vivid and I don't really know which one it should point to, but we can also create more than just thegazebo5
key in rosdep. We could instead create a matching set of keys for rosdep which mimic the ubuntu layout. Anyways, I'll have to wait to get the rosdep keys sorted out before I can release.The text was updated successfully, but these errors were encountered: