Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jade Release #318

Closed
wjwwood opened this issue Apr 29, 2015 · 19 comments
Closed

Jade Release #318

wjwwood opened this issue Apr 29, 2015 · 19 comments

Comments

@wjwwood
Copy link
Member

wjwwood commented Apr 29, 2015

Since we can't decide on whether or not to break up gazebo_ros_control (#179 (comment)), I propose we release everything but gazebo_ros_control into jade for now.

I've already made a jade-devel branch on which I've updated the use of the gazebo rosdep key with the new gazebo5 rosdep key: d236df8

This is necessary because on Trusty the gazebo rosdep key is already in reference to Gazebo2. And since Jade is on Trusty as well we need a different rosdep key for Gazebo5, hence gazebo5.

@scpeters or @j-rivero we need to get an entry in the rosdep database for gazebo5 for Trusty, Utopic, and Vivid. I looked briefly at the available gazebo packages in Vivid and I don't really know which one it should point to, but we can also create more than just the gazebo5 key in rosdep. We could instead create a matching set of keys for rosdep which mimic the ubuntu layout. Anyways, I'll have to wait to get the rosdep keys sorted out before I can release.

@wjwwood
Copy link
Member Author

wjwwood commented Apr 29, 2015

@j-rivero
Copy link
Contributor

We usually recommend two ways of using gazebo5 packages:

  • Install the gazebo5 package if you plan on using gazebo but don't make development on top of it.
  • Install the libgazebo5-dev package (libgazebo-dev is just a transitional package) if you plan on developing on top of gazebo.

Given the nature of ROS and rosdep, I would say that we want to go with libgazebo5-dev.

@wjwwood
Copy link
Member Author

wjwwood commented Apr 29, 2015

Well, the particular use we are describing is for a package building a plugin. But it seems more than that, we should probably have libgazebo5 and libgazebo5-dev so that we can properly model the build time vs runtime dependencies. So I'd say we want a few rosdep keys:

  • rosdep -> ubuntu
  • gazebo5 -> gazebo5
  • libgazebo5 -> libgazebo5
  • libgazebo5-dev -> libgazebo5-dev

@scpeters
Copy link
Member

I think libgazebo5-dev should be a build_depend and gazebo5 should be run_depend, since the gazebo and gzserver executables are only present in the gazebo5 package and not the -dev package. Both of these depend on libgazebo5, so I'm not sure we need an explicit key for that.

@wjwwood
Copy link
Member Author

wjwwood commented Apr 29, 2015

Well, a package which provides just a plugin (doesn't run gazebo) would just need to build depend on libgazebo5-dev and run depend on libgazebo5. Then a package which uses that plugin might actually run gazebo in a launch file or something and that would depend on gazebo5 and this plugin package.

In practice the packages which provide the plugins will likely also have examples and so having a run depend on gazebo5 is probably needed anyways. So strictly speaking we don't need the rule, but I think it would be good to have for completeness.

Either way, I'll leave it to you guys to come up with the correct rosdep key and open a pull requests against ros/rosdistro.

Thanks.

@j-rivero
Copy link
Contributor

Both of these depend on libgazebo5, so I'm not sure we need an explicit key for that.

+1, I can not imaging a valid use case right now, so we can go with only two.

@scpeters
Copy link
Member

According to @wjwwood 's comment, it is possible to run_depend on libgazebo5 (kobuki_gazebo_plugins for example), but I'm not sure if there's any advantage to the added complexity.

EDIT: I mean this is an example package that has only a plugin and no examples, so it wouldn't need gazebo5 as a run_depend

@scpeters
Copy link
Member

I just made a pull request for the rosdep keys (ros/rosdistro#8243), and made the build_depends point to libgazebo5-dev instead of gazebo5 (a2fb41c).

@wjwwood
Copy link
Member Author

wjwwood commented Apr 29, 2015

Great, you might want to touch the change logs and then we'll need to do a release (bumping the minor version) and then do the release into Jade.

@scpeters
Copy link
Member

Changelogs in 193dcbb

@j-rivero
Copy link
Contributor

Well, a package which provides just a plugin (doesn't run gazebo) would just need to build depend on libgazebo5-dev and run depend on libgazebo5

I see the point, it is valid yes, but I agree with Steve, the number of use cases to use libgazebo5 instead of gazebo5 is really minimal and does not worth it to introduce complexity with another key. So my +1 to the current status.

I suppose that we can add some notes about the gazebo key migration (from just gazebo to gazebo5/libgazebo5-dev) so the people coming from Indigo know well what to do to change. Maybe it also interesting to mention our Migration.md document

@wjwwood
Copy link
Member Author

wjwwood commented Apr 29, 2015

I suppose that we can add some notes about the gazebo key migration (from just gazebo to gazebo5/libgazebo5-dev) so the people coming from Indigo know well what to do to change. Maybe it also interesting to mention our Migration.md document

Please also put it or link to it in the Jade migration page: http://wiki.ros.org/jade/Migration

@j-rivero
Copy link
Contributor

Please also put it or link to it in the Jade migration page: http://wiki.ros.org/jade/Migration

I've added some quick notes to the document. http://wiki.ros.org/jade/Migration#Gazebo_Simulator

@wjwwood
Copy link
Member Author

wjwwood commented Apr 30, 2015

Thanks @j-rivero that looks awesome.

@scpeters
Copy link
Member

I'm going to update it since libgazebo5-dev actually doesn't depend on gazebo5. The -dev package has headers and development files, while the gzserver, gzlient, and gazebo executables are only in gazebo5.

@scpeters
Copy link
Member

I just updated the wiki page; please review: http://wiki.ros.org/jade/Migration#Gazebo_Simulator

@j-rivero
Copy link
Contributor

+1, thanks Steve

@scpeters
Copy link
Member

ros/rosdistro#8259

@wjwwood
Copy link
Member Author

wjwwood commented Apr 30, 2015

Thanks!

@wjwwood wjwwood closed this as completed Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants