gazebo_ros: fix cpplint and flake8 errors #1355
Conversation
| #include <geometry_msgs/msg/point.hpp> | ||
| #include <geometry_msgs/msg/point32.hpp> | ||
| #include <geometry_msgs/msg/pose.hpp> | ||
| #include <geometry_msgs/msg/quaternion.hpp> | ||
| #include <geometry_msgs/msg/transform.hpp> | ||
| #include <geometry_msgs/msg/vector3.hpp> | ||
| #include <ignition/math/Pose3.hh> | ||
| #include <ignition/math/Quaternion.hh> | ||
| #include <ignition/math/Vector3.hh> |
There was a problem hiding this comment.
I guess cpplint thinks these are c-system headers? The other option is the use double-quotes for all includes not from the standard library. I don't have a preference either way though.
There was a problem hiding this comment.
I guess the new version of cpplint thinks that .hh headers are C headers instead of C++
I can switch to double quotes if you think that's a better option
There was a problem hiding this comment.
I don't have a preference; I don't think there's an objective reason to use double-quotes. If we use double-quotes, I think we can keep the .hh files below any standard library headers 🤷. The size of the diff might actually turn out to be larger if we switch to double-quotes.
|
@ros-pull-request-builder retest this please |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
I've rebased the changes on |
|
In retrospect, I think cpplint is at fault for considering files with the .hh extension to be C headers instead of C++ headers. I've proposed a patch upstream: ament/ament_lint#374 Note, even with the upstream patch, there are still a number of include order lint errors to address. |
|
flake8 fixes were merged in #1380 |
There are lots of cpplint errors since a recent change in rolling. This fixes the new
build_ordererrors in thegazebo_rospackage.gazebo_pluginswill be addressed in a separate pull request.