Modifying sip_configure for improper lib names #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to sip_configure.py for whether the lib name is None, an empty string or whitespace.
For example, when I build qt_gui_cpp this is the diff for the qt_gui_cpp_sip.so Makefile if I ask CMakeLists to
find_package(Boost...)
(even if the code doesn't use it) and if I don't.Or condensed:
And this is the line from the Makefile with this bug fix