[melodic] pass ROS_BUILD_SHARED_LIBS to use visibility control properly. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirk-thomas This is ready for review and merge. Thanks! |
|
@dirk-thomas Friendly ping. |
|
@dirk-thomas Following up. Any feedback would be appreciated. |
dirk-thomas
reviewed
May 26, 2020
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many ROS packages adopt this visibility control header to make the packages Windows-compatible. And the visibility control is conditionally guarded by
ROS_BUILD_SHARED_LIBSwhich is defined by catkin in CMake file.However, for
sipmodule, it is running its own Makefile generated bysip, and this important definition (ROS_BUILD_SHARED_LIBS) is not automatically inherited. In such case, when it is building thesipmodule and ROS visibility control headers are in use there, it doesn't use the expected visibility control code path.