rqt_image_view: Fixed image shirinking problem. #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablasdel
changed the title
|
The patch does not look like the right fix for the problem. Can you please try to modify the following two lines to
|
|
modified the code according to suggestion and it seems to work pretty well. |
* upstream/groovy-devel: added check to ensure we do not fail if PyQt5 is not in sys.modules
dirk-thomas
pushed a commit
that referenced
this pull request
Dec 10, 2014
|
Thanks, I have manually merged it in: 95f0155 |
mjyc
pushed a commit
to mjyc/rqt_common_plugins
that referenced
this pull request
Feb 5, 2015
* upstream/groovy-devel: Fix version clash when PyQt5 is installed Remove dead nodes from memory and rebuild uri cache when nodes are restarted fix image shrinking problem ros-visualization#291 rqt_reconfigure: Restore support for parameter groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the greatestCommonDivisor is 1, every time
setAspectRatiofunction gets called, width & height in aspect_ratio_ decreases. As a result, rqt_image_view shrinks the image as the times goes. This is one approach to prevent such problem.