Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shebang line for python3 support #6

Merged

Conversation

mikaelarguedas
Copy link
Contributor

Similar to ros-visualization/rqt_graph#43

Without this change the script cannot be rosrun on Noetic/Focal and results in:
/usr/bin/env: ‘python’: No such file or directory

Python scripts need to be installed using catkin_install_python for the shebang line to be rewritten to point to python3. More details at https://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-noetic-ninjemys-release/14262/22

@dirk-thomas
Copy link
Contributor

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit e50227b into ros-visualization:master Jun 1, 2020
@mikaelarguedas mikaelarguedas deleted the fix_python3_shebang branch June 1, 2020 19:31
@mikaelarguedas
Copy link
Contributor Author

@dirk-thomas or current maintainer, is it possible to make a Noetic release with this patch ? Thanks!

/cc @sloretz

@dirk-thomas
Copy link
Contributor

I am sorry, but I am not involved with the project at this point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants