Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race condition in SimpleActionClient #176

Open
machinekoder opened this issue Nov 23, 2020 · 1 comment
Open

race condition in SimpleActionClient #176

machinekoder opened this issue Nov 23, 2020 · 1 comment

Comments

@machinekoder
Copy link

machinekoder commented Nov 23, 2020 •
edited
Loading

I noticed that wait_for_result() may cause a race condition. The done_condition lock is not used when setting the simple_state, therefore done_db might not have been called when wait_for_result returns.

see
https://github.com/ros/actionlib/blob/noetic-devel/actionlib/src/actionlib/simple_action_client.py#L239-L243
and
https://github.com/ros/actionlib/blob/noetic-devel/actionlib/src/actionlib/simple_action_client.py#L137-L138
@machinekoder
Copy link
Author

related to #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@machinekoder