Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interfaces for easier mocking #183

Open
rcywongaa opened this issue Jan 14, 2021 · 0 comments
Open

Implement interfaces for easier mocking #183

rcywongaa opened this issue Jan 14, 2021 · 0 comments

Comments

@rcywongaa
Copy link

Since actionlib is frequently used as part of a larger system, it would be nice if commonly used classes, e.g. SimpleActionClient, SimpleActionServer implemented an interface so that they can be easily mocked when unit testing the rest of the system. It doesn't seem like a big / breaking change and if the core devs are agreeable, I can prolly implement it and submit a PR.

@rcywongaa rcywongaa changed the title Implement interfaces for easier mockability Implement interfaces for easier mocking Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant