Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After calling cancel_all_goals() isNewGoalAvailable returns true #196

Open
corot opened this issue Nov 25, 2021 · 0 comments
Open

After calling cancel_all_goals() isNewGoalAvailable returns true #196

corot opened this issue Nov 25, 2021 · 0 comments

Comments

@corot
Copy link
Contributor

corot commented Nov 25, 2021

If there was already a goal with PENDING status.
The action server cancels (correctly) both the ACTIVE and the PENDING goal, and sets new_goal_preempt_request_ to true.
But doesn't touch new_goal_, and so isNewGoalAvailable will keep returning true. This is a big problem, because on simple action server, isNewGoalAvailable is afaik the only way to tell if the current goal is being preempted (isNewGoalAvailable() == true)or canceled (isNewGoalAvailable() == false)

Of course this is not at all a new issue; the behavior seems to be that by design, but I would like to understand why. This change "fixes" the issue:
image

Nevertheless, even if not intended, I suppose it doesn't make much sense to PR on noetic, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant