Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove travis. #182

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Remove travis. #182

merged 1 commit into from
Apr 8, 2021

Conversation

clalancette
Copy link
Contributor

Travis no longer supports open-source, and we have test coverage
via the ROS buildfarm anyway. Just remove it here.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

@clalancette
Remove travis.
99e8fff 
Travis no longer supports open-source, and we have test coverage
via the ROS buildfarm anyway.  Just remove it here.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
hidmic
hidmic approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris! I wonder if we should do the same about appveyor.

@clalancette
Copy link
Contributor Author

Thanks Chris! I wonder if we should do the same about appveyor.

Yeah, I was thinking about it, but ultimately decided to do it separately. The main reason is that appveyor does give us some coverage that the buildfarm does not, i.e. Windows testing. So I was thinking that we should actually fix it rather than remove it.

nuclearsandwich
nuclearsandwich approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for removing Travis and Appveyor. They've already been removed from the ROS 1 branches and I think there was even an attempt to remove them in ROS 2 that got accidentally unwound when resolving a merge.

@clalancette
Copy link
Contributor Author

I'm not going to run additional CI here since this isn't a code change. Thanks for the reviews!

@clalancette clalancette merged commit 2ca2b37 into ros2 Apr 8, 2021
@clalancette clalancette deleted the clalancette/ros2-remove-travis branch April 8, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clalancette @nuclearsandwich @hidmic