Switch to unittest.mock #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mock package has been integrated into unittest since Python 3.3, which includes all supported distributions of ROS 2. Signed-off-by: Scott K Logan <logans@cottsay.net>
clalancette
approved these changes
Apr 20, 2023
|
Once we are out of Rolling sync hold, I'll merge this and do releases. |
clalancette
added a commit
to ros2/ros_buildfarm_config
that referenced
this pull request
May 1, 2023
With the merge of ros/urdf_parser_py#78, it should build now. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
See also ros2/ros_buildfarm_config#272 , where we unblacklist this. |
cottsay
pushed a commit
to ros2/ros_buildfarm_config
that referenced
this pull request
May 3, 2023
With the merge of ros/urdf_parser_py#78, it should build now. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mock package has been integrated into unittest since Python 3.3, which includes all supported distributions of ROS 2.
Should resolve the current build failures on RHEL 9: https://build.ros2.org/view/Rbin_rhel_el964/job/Rbin_rhel_el964__urdfdom_py__rhel_9_x86_64__binary/