-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crate imports_granularity requires nightly #395
Comments
Isn't this something that should be mentioned directly in the readmy or .rustfmt.toml as a comment? The Cargo manifest format allows comments starting with |
@maspe36 I prefer to only target stable for builds, however we could target nightly for formatting, but I wonder how much of a moving target it is. |
#396 should get us what we want. It will continue to build and test the repo using the stable channel but use nightly when checking the format. |
Ah yeah, I didn't word the second option well but #396 is exactly what I was referring to. We can close once that's merged. |
This was identified by @luca-della-vedova here.
Currently, our CI doesn't actually check that our imports are formatted with crate level import granularity. Additionally, this functionality is an unstable feature (rust-lang/rustfmt#4991) so it's only supported in nightly.
Running locally without a nightly toolchain
The way I see it, we have two options.
The text was updated successfully, but these errors were encountered: