Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Windows builds succeed or get marked as unstable even though they fail #433

Closed
brawner opened this issue Apr 15, 2020 · 4 comments
Closed

Some Windows builds succeed or get marked as unstable even though they fail #433

brawner opened this issue Apr 15, 2020 · 4 comments

Comments

@brawner
Copy link
Contributor

brawner commented Apr 15, 2020 •
edited
Loading

This may have already been resolved by #428, but I wanted to track it just in case. This ci_windows job was a complete failure, yet it was marked successful by Jenkins. @nuclearsandwich, when you have updated the jenkins nodes, I'll rerun it to test this out.
@brawner
Copy link
Contributor Author

brawner commented Apr 15, 2020

Err, actually it was this one.
Build Status

@hidmic
Copy link

hidmic commented Apr 23, 2020

@nuclearsandwich has that nodes update happened already?

@brawner
Copy link
Contributor Author

brawner commented Apr 23, 2020

We found out that %errorlevel% in || exit /b %errorlevel% (#428) was being expanded when the ci_job script was being read, which led to builds saying success. We just fixed that in (#438).

@brawner
Copy link
Contributor Author

brawner commented May 12, 2020

I believe this has been addressed by #428 and #438. If this comes up again we can reopen this issue.

@brawner brawner closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brawner @hidmic