Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[launch] add new concept for LaunchArgument #107

Closed
wjwwood opened this issue Jul 12, 2018 · 0 comments · Fixed by #123
Closed

[launch] add new concept for LaunchArgument #107

wjwwood opened this issue Jul 12, 2018 · 0 comments · Fixed by #123
Labels
enhancement New feature or request
Milestone

Comments

@wjwwood
Copy link
Member

wjwwood commented Jul 12, 2018

The idea behind the concept of LaunchArgument is that it should be something you can declare (perhaps as an Action) in a launch description which indicates some input configurations to the launch description.

If the launch description is included by another launch description then the arguments would be part of that action, but if the launch description is "run" by ros2 launch it would be possible to pass them as command line arguments.

This is partially equivalent to the <arg> tag in roslaunch from ROS 1:

https://wiki.ros.org/roslaunch/XML/arg

It should take a name, optionally a default value, optionally documentation for the argument, and possibly other things commonly associated with command line arguments, like being a flag rather than a key-value option or with special validation logic (is it the right type or in the right range)? Initially it should always have a type of string, and it can be evaluated by the things consuming it.

The result (default value or user provided) would be stored in a LaunchConfiguration of the same name.

@wjwwood wjwwood added the enhancement New feature or request label Jul 12, 2018
@wjwwood wjwwood added this to the crystal milestone Jul 12, 2018
@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Aug 14, 2018
@wjwwood wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 23, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant